Add macOS Universal Binary runtime support#625
Open
nowsprinting wants to merge 1 commit intobdovaz:masterfrom
Open
Add macOS Universal Binary runtime support#625nowsprinting wants to merge 1 commit intobdovaz:masterfrom
nowsprinting wants to merge 1 commit intobdovaz:masterfrom
Conversation
Support osx (without architecture suffix) runtime identifier for native libraries, enabling Universal Binary packages that work on both Intel and Apple Silicon Macs. Changes: - Modified NativeLibraries.cs to accept osx runtime identifier without architecture - Use UnityCpu.AnyCpu for osx Universal Binary native libraries - Added test case for osx Universal Binary native libraries Related: GlitchEnzo/NuGetForUnity#744 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
@bdovaz san, Please let me know if I can help move this forward. Thanks! |
Owner
|
I have my doubts that you used Claude to create the PR, that is, you didn't do it yourself, right? Having delegated to AI makes me doubt that you really know whether the changes that have been made make sense or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osx(without architecture suffix) runtime identifier for native librariesUnityCpu.AnyCpufor osx Universal Binary native librariesChanges
NativeLibraries.csto accept osx runtime identifier without architecture suffixExamples of Universal Binary packages
Related
Test plan
RegistryTests- all 457 tests passed🤖 Generated with Claude Code