Skip to content

commented out unused code and remove setTextAndSelection from receive… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarouboy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

commented out unused code and remove setTextAndSelection from receive… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d9b386
commented out unused code and remove setTextAndSelection from receive…
tarouboy Feb 17, 2021
726dc62
Test
tarouboy Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions android/src/main/java/gr/dokimakis/b/nolagtextinput/ReactEditText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,9 @@ public int incrementAndGetEventCounter() {
}

public void maybeSetTextFromJS(ReactTextUpdate reactTextUpdate) {
mIsSettingTextFromJS = true;
maybeSetText(reactTextUpdate);
mIsSettingTextFromJS = false;
// mIsSettingTextFromJS = true;
// maybeSetText(reactTextUpdate);
// mIsSettingTextFromJS = false;
}

public void maybeSetTextFromState(ReactTextUpdate reactTextUpdate) {
Expand Down Expand Up @@ -503,10 +503,10 @@ public void maybeSetText(ReactTextUpdate reactTextUpdate) {
// current text need to be adapted to the new text. Since TextView#setText() will remove or
// reset some of these spans even if they are set directly, SpannableStringBuilder#replace() is
// used instead (this is also used by the keyboard implementation underneath the covers).
SpannableStringBuilder spannableStringBuilder =
new SpannableStringBuilder(reactTextUpdate.getText());
manageSpans(spannableStringBuilder);
mContainsImages = reactTextUpdate.containsImages();
// SpannableStringBuilder spannableStringBuilder =
// new SpannableStringBuilder(reactTextUpdate.getText());
// manageSpans(spannableStringBuilder);
// mContainsImages = reactTextUpdate.containsImages();

// When we update text, we trigger onChangeText code that will
// try to update state if the wrapper is available. Temporarily disable
Expand All @@ -518,15 +518,15 @@ public void maybeSetText(ReactTextUpdate reactTextUpdate) {
if (reactTextUpdate.getText().length() == 0) {
setText(null);
} else {
String updatedText = reactTextUpdate.getText().toString();
int selectionStart = reactTextUpdate.getText().length();
int selectionEnd = reactTextUpdate.getText().length();

// When we update text, we trigger onChangeText code that will
// try to update state if the wrapper is available. Temporarily disable
// to prevent an infinite loop.
setText(updatedText);
setSelection(selectionStart, selectionEnd);
// String updatedText = reactTextUpdate.getText().toString();
// int selectionStart = reactTextUpdate.getText().length();
// int selectionEnd = reactTextUpdate.getText().length();
//
// // When we update text, we trigger onChangeText code that will
// // try to update state if the wrapper is available. Temporarily disable
// // to prevent an infinite loop.
// setText(updatedText);
// setSelection(selectionStart, selectionEnd);
}
mDisableTextDiffing = false;

Expand Down
42 changes: 21 additions & 21 deletions android/src/main/java/gr/dokimakis/b/nolagtextinput/ReactTextInputManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,9 @@ public void receiveCommand(
case SET_MOST_RECENT_EVENT_COUNT:
// TODO: delete, this is no longer used from JS
break;
case SET_TEXT_AND_SELECTION:
this.receiveCommand(reactEditText, "setTextAndSelection", args);
break;
// case SET_TEXT_AND_SELECTION:
// this.receiveCommand(reactEditText, "setTextAndSelection", args);
// break;
}
}

Expand All @@ -230,24 +230,24 @@ public void receiveCommand(
case "blurTextInput":
reactEditText.clearFocusFromJS();
break;
case "setTextAndSelection":
int mostRecentEventCount = args.getInt(0);
if (mostRecentEventCount == UNSET) {
return;
}

String text = args.getString(1);

int start = args.getInt(2);
int end = args.getInt(3);
if (end == UNSET) {
end = start;
}

reactEditText.maybeSetTextFromJS(
getReactTextUpdate(text, mostRecentEventCount, start, end));
reactEditText.maybeSetSelection(mostRecentEventCount, start, end);
break;
// case "setTextAndSelection":
// int mostRecentEventCount = args.getInt(0);
// if (mostRecentEventCount == UNSET) {
// return;
// }
//
// String text = args.getString(1);
//
// int start = args.getInt(2);
// int end = args.getInt(3);
// if (end == UNSET) {
// end = start;
// }
//
// reactEditText.maybeSetTextFromJS(
// getReactTextUpdate(text, mostRecentEventCount, start, end));
// reactEditText.maybeSetSelection(mostRecentEventCount, start, end);
// break;
}
}

Expand Down