Skip to content

Migrate successful build fixtures to testBuild#269

Merged
bcomnes merged 1 commit into
fix/copy-path-resolutionfrom
chore/migrate-tests-to-test-build
Jun 26, 2026
Merged

Migrate successful build fixtures to testBuild#269
bcomnes merged 1 commit into
fix/copy-path-resolutionfrom
chore/migrate-tests-to-test-build

Conversation

@bcomnes

@bcomnes bcomnes commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Stacked on #251.

Summary

Migrates successful one-shot build fixtures to use the new top-level testBuild() helper introduced in #251.

Updated tests:

  • test-cases/default-layout/index.test.js
  • test-cases/drafts/index.test.js
  • test-cases/general-features/index.test.js

These tests now build into isolated temporary destinations and register build.cleanup() with t.after().

Tests intentionally left on direct DomStack usage:

  • error-path fixtures, because testBuild() throws before returning cleanup on failing builds
  • nested-dest, because it specifically verifies building into a nested destination under the source tree
  • watch tests, because they need direct DomStack.watch() control and stable temp source/dest paths
  • constructor/type smoke tests, because they are not one-shot successful build fixtures

Validation

  • node --test --test-reporter spec test-cases/default-layout/index.test.js test-cases/drafts/index.test.js test-cases/general-features/index.test.js
  • npm run test:tsc
  • npm run test:neostandard
  • npm run test:node-test

Copilot AI review requested due to automatic review settings June 26, 2026 23:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bcomnes bcomnes merged commit 4fe23ab into fix/copy-path-resolution Jun 26, 2026
10 checks passed
@bcomnes bcomnes deleted the chore/migrate-tests-to-test-build branch June 26, 2026 23:44
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28271434076

Coverage increased (+0.6%) to 92.55%

Details

  • Coverage increased (+0.6%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4254
Covered Lines: 4027
Line Coverage: 94.66%
Relevant Branches: 699
Covered Branches: 557
Branch Coverage: 79.69%
Branches in Coverage %: Yes
Coverage Strength: 74.34 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants