Update to BarChart.js to resolve sorting issue#8
Open
toridenney wants to merge 1 commit intobchao1:masterfrom
Open
Update to BarChart.js to resolve sorting issue#8toridenney wants to merge 1 commit intobchao1:masterfrom
toridenney wants to merge 1 commit intobchao1:masterfrom
Conversation
stefan-hudelmaier
suggested changes
Aug 15, 2020
| // Sorted list of results based on the axis | ||
| return [toSort.reduce((ret, item, idx) => ({ | ||
| ...ret, ...{ [item.name]: idx } | ||
| }), {}), minVal, maxVal] |
There was a problem hiding this comment.
In lines 22 and 56 the return value at index 1 is interpreted as maxVal, not minVal. So you should either change the order here or in the mentioned lines (or not return minVal at all, as it does not seem to be needed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.