Skip to content

Fix data sort, use componentDidUpdate #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crsohr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix data sort, use componentDidUpdate #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b65333e
Use componentDidUpdate
Mar 31, 2020
762f526
Fix data sort
Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/BarChart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ class BarChart extends React.Component {
}
}

componentWillReceiveProps(nextProps) {
if (nextProps.start) {
componentDidUpdate(prevProps) {
if (this.props.start && !prevProps.start) {
var intervalId = setInterval(this.update, this.props.timeout + this.props.delay);
this.setState({intervalId: intervalId});
}
Expand Down Expand Up @@ -71,7 +71,7 @@ class BarChart extends React.Component {
val: this.props.data[name][i]
};
});
toSort.sort((left, right) => descending ? left.val < right.val : left.val > right.val);
toSort.sort((left, right) => descending ? left.val < right.val ? 1: left.val > right.val ? -1 : 0 : left.val < right.val ? 1 : left.val < right.val ? -1 : 0);
toSort = toSort.slice(0, this.maxItems);
const maxVal = Math.max.apply(Math, toSort.map(item => item.val));
return [toSort.reduce((ret, item, idx) => ({
Expand Down Expand Up @@ -131,4 +131,4 @@ class BarChart extends React.Component {
}
}

export default BarChart;
export default BarChart;