Feat/devsu 2848 update seqqc json#109
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #109 +/- ##
===========================================
+ Coverage 83.46% 83.55% +0.08%
===========================================
Files 18 18
Lines 2546 2566 +20
===========================================
+ Hits 2125 2144 +19
- Misses 421 422 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces support for a new seqQC section in IPR report content by extending the JSON schema, adding a normalization step to translate legacy/production seqQC field names to the schema format, and adding tests to validate both normalization and upload behavior.
Changes:
- Added
seqQCtocontent.spec.jsonso reports can include sequencing QC metadata. - Added
normalize_seqqc()and invoked it before schema validation to remap legacyseqQCkeys to schema-compliant names. - Added unit/integration tests covering
seqQCnormalization and confirmingseqQCpersists through upload/load.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_ipr/test_upload.py |
Extends upload fixture content with seqQC and verifies it is present after report upload/load. |
tests/test_ipr/test_inputs.py |
Adds unit tests for normalize_seqqc() behavior across legacy, normalized, missing, and multi-item inputs. |
pori_python/ipr/main.py |
Calls normalize_seqqc(content) prior to schema validation in ipr_report(). |
pori_python/ipr/inputs.py |
Implements normalize_seqqc() to map production/legacy seqQC keys to schema keys. |
pori_python/ipr/content.spec.json |
Adds seqQC array schema definition to the report content specification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| # Replace the item with normalized version | ||
| content['seqQC'][i] = normalized_item | ||
|
|
||
| return content |
There was a problem hiding this comment.
side-effect-driven programming... Do you still want to return?
There was a problem hiding this comment.
Discussed offline, I see what you're saying and will fix
No description provided.