Skip to content

Feat/devsu 2848 update seqqc json#109

Open
elewis2 wants to merge 9 commits into
developfrom
feat/DEVSU-2848-update-seqqc-json
Open

Feat/devsu 2848 update seqqc json#109
elewis2 wants to merge 9 commits into
developfrom
feat/DEVSU-2848-update-seqqc-json

Conversation

@elewis2
Copy link
Copy Markdown
Collaborator

@elewis2 elewis2 commented Apr 20, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.55%. Comparing base (8777c66) to head (e2c25ef).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
pori_python/ipr/inputs.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #109      +/-   ##
===========================================
+ Coverage    83.46%   83.55%   +0.08%     
===========================================
  Files           18       18              
  Lines         2546     2566      +20     
===========================================
+ Hits          2125     2144      +19     
- Misses         421      422       +1     
Flag Coverage Δ
unittests 83.55% <94.11%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elewis2 elewis2 marked this pull request as ready for review May 11, 2026 19:26
@elewis2 elewis2 requested a review from Copilot May 11, 2026 19:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces support for a new seqQC section in IPR report content by extending the JSON schema, adding a normalization step to translate legacy/production seqQC field names to the schema format, and adding tests to validate both normalization and upload behavior.

Changes:

  • Added seqQC to content.spec.json so reports can include sequencing QC metadata.
  • Added normalize_seqqc() and invoked it before schema validation to remap legacy seqQC keys to schema-compliant names.
  • Added unit/integration tests covering seqQC normalization and confirming seqQC persists through upload/load.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/test_ipr/test_upload.py Extends upload fixture content with seqQC and verifies it is present after report upload/load.
tests/test_ipr/test_inputs.py Adds unit tests for normalize_seqqc() behavior across legacy, normalized, missing, and multi-item inputs.
pori_python/ipr/main.py Calls normalize_seqqc(content) prior to schema validation in ipr_report().
pori_python/ipr/inputs.py Implements normalize_seqqc() to map production/legacy seqQC keys to schema keys.
pori_python/ipr/content.spec.json Adds seqQC array schema definition to the report content specification.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pori_python/ipr/inputs.py
Comment thread pori_python/ipr/inputs.py Outdated
Comment thread pori_python/ipr/inputs.py
Comment thread pori_python/ipr/content.spec.json
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Comment thread pori_python/ipr/main.py
Comment thread pori_python/ipr/inputs.py Outdated
elewis2 and others added 2 commits May 11, 2026 13:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comment thread pori_python/ipr/main.py
Comment thread pori_python/ipr/content.spec.json
Comment thread pori_python/ipr/inputs.py
# Replace the item with normalized version
content['seqQC'][i] = normalized_item

return content
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side-effect-driven programming... Do you still want to return?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, I see what you're saying and will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants