Skip to content

Feature/replace caching#102

Draft
creisle wants to merge 12 commits intodevelopfrom
feature/replace-caching
Draft

Feature/replace caching#102
creisle wants to merge 12 commits intodevelopfrom
feature/replace-caching

Conversation

@creisle
Copy link
Member

@creisle creisle commented Feb 12, 2026

This replaces the custom caching with a standard caching library. It is very useful if you want to cache between scripts to (for example) an sqlite database so if you were generating many reports right after one another you could so so without having to make as many API calls. By default this will just use an in-memory cache (similar to the current behaviour) unless a cache_name is given.

However I am not sure if the one function i deleted is in use anywhere so that should be double checked with other stakeholders.

@creisle creisle requested a review from elewis2 February 12, 2026 07:33
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.54%. Comparing base (b728677) to head (135df03).

Files with missing lines Patch % Lines
pori_python/graphkb/util.py 85.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #102      +/-   ##
===========================================
- Coverage    83.09%   82.54%   -0.55%     
===========================================
  Files           18       18              
  Lines         2466     2452      -14     
===========================================
- Hits          2049     2024      -25     
- Misses         417      428      +11     
Flag Coverage Δ
unittests 82.54% <85.71%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants