Skip to content

Dev & Prod Notifications#5229

Merged
brettedw merged 19 commits intomainfrom
task/firebase-dev-prod
Mar 18, 2026
Merged

Dev & Prod Notifications#5229
brettedw merged 19 commits intomainfrom
task/firebase-dev-prod

Conversation

@brettedw
Copy link
Collaborator

@brettedw brettedw commented Mar 16, 2026

  • Splits Firebase projects into Prod and Dev
  • We can now have both prod and dev apps installed on devices, for clear notification separation
  • On iOS, it creates 2 Xcode targets and schemes, ASA Go and ASA Go Dev, with separate bundle IDs and a dev plist.
    • I initially tried to keep iOS to a one target/build config setup, but that broke Capacitor live reload because ionic capacitor run ios expects the configured scheme in capacitor.config.ts to match an app target.
    • This keeps the simpler two target structure so live reload and Capacitor scheme selection continue to work
  • On Android, it uses 'flavors' for choosing build variants and selecting Firebase config
  • On the Capacitor side, APP_ENV selects the correct iOS scheme and Android flavor during cap sync, and the package.json sync scripts were updated to reflect this
  • Updated README and created more in depth Notifications.md for more details
  • Follows some common practices of having different installs for prod and dev:
  • closes ASA Go: Separate dev/prod FCM service #5188

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.17%. Comparing base (73c2d50) to head (4d2f6d8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pp/src/main/java/ca/bc/gov/asago/MainActivity.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5229      +/-   ##
============================================
- Coverage     69.24%   69.17%   -0.07%     
- Complexity        0       26      +26     
============================================
  Files           393      471      +78     
  Lines         16295    18241    +1946     
  Branches       1827     2146     +319     
============================================
+ Hits          11283    12619    +1336     
- Misses         4472     5004     +532     
- Partials        540      618      +78     
Flag Coverage Δ
android 24.68% <0.00%> (?)
asa_go 77.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brettedw brettedw closed this Mar 17, 2026
@brettedw brettedw reopened this Mar 17, 2026
@brettedw brettedw marked this pull request as ready for review March 17, 2026 21:12
@brettedw brettedw requested a review from conbrad March 17, 2026 23:26
Copy link
Collaborator

@conbrad conbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

brettedw and others added 2 commits March 18, 2026 10:23
Co-authored-by: Conor Brady <con.brad@gmail.com>
Copy link
Collaborator

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks for tackling this.

@sonarqubecloud
Copy link

@brettedw brettedw merged commit 3c32a4c into main Mar 18, 2026
37 checks passed
@brettedw brettedw deleted the task/firebase-dev-prod branch March 18, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASA Go: Separate dev/prod FCM service

3 participants