Skip to content

Snow warning#5227

Merged
dgboss merged 14 commits intomainfrom
task/snow-message/5226
Mar 18, 2026
Merged

Snow warning#5227
dgboss merged 14 commits intomainfrom
task/snow-message/5226

Conversation

@dgboss
Copy link
Collaborator

@dgboss dgboss commented Mar 16, 2026

  • Display a warning icon if the date of interest (aka rasterDate) is after March 8, 2026 and the snowDate is March 8, 2026.
  • Display a modal with a message about snow data. Modal has an option to 'Don't show again' which should be respected when re-loading the page.
  • Clicking the warning icon should re-display the modal regardless of the 'Don't show again message.
  • Using the calendar control to move forward/back should result in the warning icon appearing/disappearing.

TESTING

  1. To test locally fire up SFMS Insights and look at the last available snow date in the UI.
  2. Edit SFMSInsightsPage.tsx and set const TEMP_LAST_SNOW = DateTime.fromISO('{last_snow_date_from_step_1}')

Closes: #5226

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.24%. Comparing base (f9d331f) to head (a2c3c29).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/features/sfmsInsights/pages/SFMSInsightsPage.tsx 87.50% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5227      +/-   ##
==========================================
+ Coverage   69.20%   69.24%   +0.03%     
==========================================
  Files         393      393              
  Lines       16265    16295      +30     
  Branches     1822     1827       +5     
==========================================
+ Hits        11257    11283      +26     
- Misses       4471     4472       +1     
- Partials      537      540       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dgboss dgboss requested review from brettedw and conbrad March 18, 2026 00:01
Copy link
Collaborator

@brettedw brettedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dgboss dgboss merged commit 73c2d50 into main Mar 18, 2026
33 of 34 checks passed
@dgboss dgboss deleted the task/snow-message/5226 branch March 18, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SFMS Insights: Add message indicating that snow coverage data is stale

3 participants