chore(innkeeper): upgrade bcrypt to 5.x and add 72-byte compat#1852
Merged
chore(innkeeper): upgrade bcrypt to 5.x and add 72-byte compat#1852
Conversation
…ultitenant/connections to main Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Deployment URLs ready for review. |
loneil
previously approved these changes
Feb 25, 2026
Collaborator
loneil
left a comment
There was a problem hiding this comment.
I switched the PR over to manual reservation approval and confirmed the generated password works all good. Tenant creation, Login and API keys work
esune
requested changes
Feb 25, 2026
plugins/traction_innkeeper/traction_innkeeper/v1_0/innkeeper/bcrypt_compat.py
Show resolved
Hide resolved
Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
Contributor
Author
|
@esune I've addressed your 2 comments, lets wait for the tests to complete then I'm happy to merge this |
loneil
approved these changes
Feb 25, 2026
esune
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades bcrypt from 4.2.1 to 5.x in the traction-innkeeper plugin and keeps the app working under bcrypt 5’s 72-byte password limit.
Changes
^5.0.0inplugins/traction_innkeeper/pyproject.toml.bcrypt_compat.pywithlimit_for_bcrypt()and use it inutils.pyandtenant_manager.pyso all inputs tohashpw/checkpware capped at 72 bytes (bcrypt 5.x raisesValueErrorfor longer inputs; 4.x truncated silently).multitenant-providerandconnections(acapy-plugins) are set torev = "main"because 1.4.0 pins bcrypt 4.x and would conflict with bcrypt 5.x. Only these two plugins are onmain; no other acapy-plugins were changed.test_limit_for_bcrypt_long_password; all 249 innkeeper tests pass with ruff lint/format and coverage.Note on
rev = "main"Using
mainis temporary until the acapy-plugins repo has a release that uses bcrypt ^5.0.0 formultitenant_providerandconnections. Once that release exists, we should switch these dependencies back to a tag (e.g.rev = "1.5.1") instead ofmain, so the innkeeper depends on a stable release instead of the current main branch.