Open
Conversation
unit tests don't show any particular failure relating to this change. added failsafes to go back to user:pass if iam is unavailable Add role switching in Alembic migrations via DB_OWNER_ROLE env var
COPY TO STDOUT is a tradeoff because all rows are loaded into memory first rather than streamed. For a job that runs periodically and generates a CSV export, that should be fine. Since this is possibly business logic please take a look at this commit to ensure things are okay.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added IAM capabilities with a user:pass fallback if an IAM is not present.
One thing we ran into is that csv_export uses a function that is exclusive to psycopg and not pg8000. This implementation should fix this.
The tradeoff is that instead COPY TO STDOUT all rows are loaded into memory first rather than streamed. For a job that runs periodically and generates a CSV export, that should be fine. Otherwise I believe the Alembic flow satisfies the requirements