30032 - NR Payments - Renewal Payments do not have option to add Folio Number by hfekete · Pull Request #853 · bcgov/namerequest

hfekete · 2025-11-08T00:20:19Z

Description of changes:

if there was a folio number during first payment, then we will apply same folio number for the RENEW payments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

…ady had it - bump version to 5.8.3

hfekete · 2025-11-08T00:20:39Z

/gcbrun

bcregistry-sre · 2025-11-08T00:22:19Z

Temporary Url for review: https://namerequest-dev--pr-853-3jp1nzj9.web.app

…TE filter

hfekete · 2025-11-10T19:35:50Z

/gcbrun

bcregistry-sre · 2025-11-10T19:37:33Z

Temporary Url for review: https://namerequest-dev--pr-853-3jp1nzj9.web.app

stevenc987

Do you think if you need to update the length for the database so you wouldn't get error when you save the data more than 40 characters? Other than that, the codes are OK

hfekete · 2025-11-10T22:35:38Z

Do you think if you need to update the length for the database so you wouldn't get error when you save the data more than 40 characters? Other than that, the codes are OK

I am not sure, I tried creating the NRs again, here are the details:

and here are the details from the dev.requests table:

and here is brining one of them up in namex:

let me know if you think I should doublecheck smth else too, thanks !

hfekete · 2025-11-10T22:37:31Z

Do you think if you need to update the length for the database so you wouldn't get error when you save the data more than 40 characters? Other than that, the codes are OK

I am not sure, I tried creating the NRs again, here are the details:

and here are the details from the dev.requests table:

and here is brining one of them up in namex:

let me know if you think I should doublecheck smth else too, thanks !

Also, this is part of another open PR, that could be merged ahead of this one

stevenc987 · 2025-11-10T22:46:38Z

I guess they need to fix this one. When the name has more than 40 characters (my sample is 41 characters) for out of province NR, it will ask the user to enter a shorter name

stevenc987 · 2025-11-10T22:46:42Z

hfekete · 2025-11-12T17:22:51Z

when using the PR review link I was able to go with 60 chars, but trying to use NR for alberta I get this error:

Can you help me how to get to that error so I can fix it ?

Thanks !

hfekete · 2025-11-12T23:13:40Z

/gcbrun

bcregistry-sre · 2025-11-12T23:15:16Z

Temporary Url for review: https://namerequest-dev--pr-853-3jp1nzj9.web.app

hfekete · 2025-11-12T23:36:05Z

/gcbrun

bcregistry-sre · 2025-11-12T23:37:43Z

Temporary Url for review: https://namerequest-dev--pr-853-3jp1nzj9.web.app

* 30381 cleaned up some env keys and fixed breadcrumbs (#843) * - deleted obsolete key VUE_APP_BUSINESSES_URL - app = 5.5.46 - fixed Business Registry URL in Affiliation Error Modal - fixed Staff Dashboard breadcrumb * - updated browserslist --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> * 30656 Updated LaunchDarkly module to support orgs (#844) * - app version = 5.6.0 - imported latest LD JS client SDK v3.9.0 - updated UpdateUserMixin to create contexts - updated featureFlags module to use contexts * - renamed updateUser -> updateLaunchDarkly - used getter instead of computing KC roles again - combined updateUser + updateLaunchDarkly - renamed featureFlags.ts -> launchDarkly.ts - misc cleanup --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> * 30554 DBA NR magic link (#846) Co-authored-by: bobby <bobbyjin935@gmail.com> * 29274 Upgraded to Vite (#845) * - misc cleanup - updated babel config file - moved index.html from /public to / - updated index.html - deleted obsolete jest config file - app version = 5.7.0 - updated scripts in package file - deleted obsolete dependencies - added necessary dependencies - recreated pnpm lock file - updated patch to use import.meta - deleted obsolete postcss config file - added robots file - replaced process.env -> import.meta.env - replaced JEST_WORKER_ID -> VITEST - added woff2 fonts - updated font sources in CSS - replaced getBaseUrl with direct sessionstorage.getItem() - fixed some image sources - deleted obsolete payment-utils.ts - changed getConfig to non-async - added vuetify css import - changed v-img to img - deleted unused isJestRunning computed - replaced appBaseURL -> namexApiUrl - added check for valid user/org before callling UpdateLdUser - added BASE_URL to session storage - added NAMEX_API_URL to session storage - updated Vuetify import - deleted appBaseURL export - deleted commented-out console.log - commented out unneeded console.log (for now) - updated unit tests - updated types in tsconfig file - added vite config file - updated vue config file * - fixed v-icon size and color --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> * Modify README for pnpm version and commands Update pnpm installation and development commands * 30987 Upgraded to Pinia (#847) * - app version = 5.8.0 - installed Pinia dependencies - updated Getter and Action decorators - misc cleanup - created Filing Types enum - created Error interface - created Payment models - removed unneeded await for store actions - converted Vuex Modules to separate stores - created getStores plugin - cleaned up error store - cleaned up payment store - delete env config - deleted obsolete properties from main store state - deleted unneeded stateModel property - refactored actions and mutations into "sub store" - refactored getters into "sub store" - refactored state into "sub store" - created new Pinia main store from sub stores - now call mutations as functions instead of "commit" - misc cleanup / type fixes - moved getXXX in main.ts - attached Vuex store to Vue instance - mocked Vuex store for unit tests - updated misc comments - final commit with store as 3 sub-stores * - changed actions back to exported functions - changed getters back to exported functions - changed state back to exported const - updated store definition - misc fixes and cleanup - updated Reg Search API URL in example env * - changed getNrState to return NrState - cleaned up some typings - changed getNrId to return number * - attached Vuetify to Vue - use current Vuetify instance to get breakpoint * - small vault comment fixes - approve building "vue-demi" to solve "missing export" issue * - fixed "cannot read null key properties" * - updated lockfile - updated pnpm lock file - lock file with pnpm v9 * - added exclude in Vite config --------- Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> * 31112 define disabled wait time and change priority wait time to Days (#851) * define disabled wait time and change priority wait time to Days * update * lint error * Update * linting * update * 30032 - NR Payments - Renewal Payments do not have option to add Folio Number (#853) * bugfix: Add folio number to RENEW payment when the first payment already had it - bump version to 5.8.3 * chore: Update folio number assignment logic to use PaymentAction.CREATE filter * cleanup * 29381 - xpro name allowed length increased from 40 to 60 (#852) * Update `MRAS_MAX_LENGTH` constant to 60 in new-request constants * version bump * chore: bump version to 5.8.3 * Add new FF for priority wait time tooltip (#855) * 2551 update priority tooltips (#856) * update priority tooltips * Remove unnecessary newline in stats.vue * 29381 - rules and validation updates in name field (#857) * fix: name input rules logic and add xpro validation - add validation/disable button in sub search modal * fix: correct defaultRules return order in name input component * fix: update search button logic and add xpro name validation - Update `isSearchBtnDisabled` logic for button disablement - Add `isValidXproName` getter for XPRO name length validation * chore: bump version to 5.8.6 and remove unused import in search component * fix: adjust max length validation for XPRO name flow - Use dynamic max length based on `isXproFlow` condition. * 31568 - remove Release Notes link from the footer (#858) * Update `MRAS_MAX_LENGTH` constant to 60 in new-request constants * version bump * chore: bump version to 5.8.3 * fix: remove "Release Notes" link from footer and update sbc-common-components patch * build lock with pnpm 9 --------- Co-authored-by: Séverin Beauvais <severinbeauvais@users.noreply.github.com> Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca> Co-authored-by: bobdev-94 <jinbobby677@gmail.com> Co-authored-by: bobby <bobbyjin935@gmail.com> Co-authored-by: eve-git <54647458+eve-git@users.noreply.github.com>

hfekete added 5 commits November 4, 2025 11:16

Update MRAS_MAX_LENGTH constant to 60 in new-request constants

c1fe0f1

Merge branch 'main' of github.com:bcgov/namerequest

c35d37c

version bump

276f559

bugfix: Add folio number to RENEW payment when the first payment alre…

bf28cfa

…ady had it - bump version to 5.8.3

chore: Restore folio number assignment for StaffPaymentOptions.NONE

bd372fc

hfekete requested review from eve-git, flutistar, mengdong19, ozamani9gh, rarmitag, shaangill025 and stevenc987 as code owners November 8, 2025 00:20

chore: Update folio number assignment logic to use PaymentAction.CREA…

805c46f

…TE filter

stevenc987 reviewed Nov 10, 2025

View reviewed changes

chore: Revert MRAS_MAX_LENGTH constant to 40 in new-request constants

8528771

stevenc987 approved these changes Nov 12, 2025

View reviewed changes

cleanup

99ffe41

eve-git approved these changes Nov 13, 2025

View reviewed changes

hfekete merged commit 1d5a40d into bcgov:main Nov 18, 2025
8 checks passed

Conversation

hfekete commented Nov 8, 2025

Uh oh!

hfekete commented Nov 8, 2025

Uh oh!

bcregistry-sre commented Nov 8, 2025

Uh oh!

hfekete commented Nov 10, 2025

Uh oh!

bcregistry-sre commented Nov 10, 2025

Uh oh!

stevenc987 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hfekete commented Nov 10, 2025

Uh oh!

hfekete commented Nov 10, 2025

Uh oh!

stevenc987 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevenc987 commented Nov 10, 2025

Uh oh!

hfekete commented Nov 12, 2025

Uh oh!

hfekete commented Nov 12, 2025

Uh oh!

bcregistry-sre commented Nov 12, 2025

Uh oh!

hfekete commented Nov 12, 2025

Uh oh!

bcregistry-sre commented Nov 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stevenc987 left a comment •

edited

Loading

stevenc987 commented Nov 10, 2025 •

edited

Loading