31097 Feature hotfix/remove priority bubble text#850
Merged
eve-git merged 3 commits intobcgov:feature-hotfix/remove-priority-bubble-textfrom Oct 30, 2025
Conversation
eve-git
requested review from
flutistar,
mengdong19,
ozamani9gh,
rarmitag,
shaangill025 and
stevenc987
as code owners
Collaborator
Author
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://namerequest-dev--pr-850-zwje2u5a.web.app |
mengdong19
approved these changes
Oct 30, 2025
| content-class="bottom-tooltip wait-time-tooltip" | ||
| transition="fade-transition" | ||
| :disabled="isMobile" | ||
| :disabled="isMobile || !showPriorityText" |
Collaborator
There was a problem hiding this comment.
If possible, rename this to "showPriorityTooltip" to make it clear that's what is being shown or disabled.
Same for regular tooltip.
| return regularWaitTime | ||
| } else { | ||
| return (this.getStats?.regular_wait_time ?? '-') | ||
| const flagRaw = GetFeatureFlag('hardcoded_regular_wait_time') |
Collaborator
There was a problem hiding this comment.
Remember to update the check in created() (lines 116-117) so that the API stats are fetched if the FF is < 0 (ie, if it's -1 then we fetch from API).
severinbeauvais
approved these changes
Oct 30, 2025
Collaborator
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
LGTM, and I've tested this in Dev.
Please make those small changes and then you can merge it. Good luck!
Collaborator
Author
|
/gcbrun |
Collaborator
|
Temporary Url for review: https://namerequest-dev--pr-850-zwje2u5a.web.app |
eve-git
merged commit 3faaf5a
into
bcgov:feature-hotfix/remove-priority-bubble-text
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
bcgov/entity#31097
Description of changes:
31097
for Regular Waiting Days and Priority Waiting Days in NameRequest page:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).