Skip to content

Updated wait time logic to allow "0" from FF #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
severinbeauvais wants to merge 1 commit into from
Closed

Updated wait time logic to allow "0" from FF #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "name-request",
"version": "5.8.0",
"version": "5.8.1",
"private": true,
"appName": "Name Request UI",
"sbcName": "SBC Common Components",
Expand Down
18 changes: 12 additions & 6 deletions app/src/components/new-request/stats.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,20 +123,26 @@ export default class Stats extends Vue {
return (this.getStats?.auto_approved_count ?? '-')
}

/** The regular wait time, in days. */
/**
* The regular wait time, in days.
* @returns value from FF if FF is >= 0, otherwise the value from the API
*/
get regularWaitTime (): string | number {
const regularWaitTime = GetFeatureFlag('hardcoded_regular_wait_time')
if (regularWaitTime > 0) {
const regularWaitTime = GetFeatureFlag('hardcoded_regular_wait_time') as number
if (regularWaitTime >= 0) {
return regularWaitTime
} else {
return (this.getStats?.regular_wait_time ?? '-')
}
}

/** The priority wait time, in hours. */
/**
* The priority wait time, in hours.
* @returns value from FF if FF is >= 0, otherwise the value from the API
*/
get priorityWaitTime (): string | number {
const priorityWaitTime = GetFeatureFlag('hardcoded_priority_wait_time')
if (priorityWaitTime > 0) {
const priorityWaitTime = GetFeatureFlag('hardcoded_priority_wait_time') as number
if (priorityWaitTime >= 0) {
return priorityWaitTime
} else {
return (this.getStats?.priority_wait_time ?? '-')
Expand Down
4 changes: 2 additions & 2 deletions app/src/plugins/launchDarkly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ const defaultFlagSet: LDFlagSet = {
'enable-priority-checkbox': false, // by default, priority is disabled
'enable-society': false, // by default society is disabled
'enable-web-chat': false, // by default, old webchat is disabled
'hardcoded_priority_wait_time': 0, // by default, use actual wait time
'hardcoded_regular_wait_time': 0, // by default, use actual wait time
'hardcoded_priority_wait_time': -1, // by default, use actual wait time
'hardcoded_regular_wait_time': -1, // by default, use actual wait time
'supported-amalgamation-entities': [],
'supported-continuation-in-entities': [],
'supported-incorporation-registration-entities': [],
Expand Down
Loading