JASPER-792 CSO service account OAUTH. #775
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WadeBarnes
approved these changes
Jan 19, 2026
|
|
||
| public static bool IsCsoServiceAccountUser(this ClaimsPrincipal claimsPrincipal) | ||
| => claimsPrincipal.HasClaim(c => c.Type == CustomClaimTypes.PreferredUsername) && | ||
| claimsPrincipal.FindFirstValue(CustomClaimTypes.PreferredUsername).Equals("service-account-cso-jasper-dev"); |
Contributor
There was a problem hiding this comment.
should the -dev be ommited?
| "Microsoft.Hosting.Lifetime": "Information" | ||
| } | ||
| }, | ||
| "CsoKeycloak": { |
Contributor
There was a problem hiding this comment.
Should this be reflected in our [docker-compose.yaml] (https://github.com/bcgov/jasper/blob/master/docker/docker-compose.yaml) file and in Terraform too?
Contributor
Author
There was a problem hiding this comment.
missed pushing a commit, and updated.
| } | ||
|
|
||
| resource "aws_secretsmanager_secret" "keycloak_cso_secret" { | ||
| name = "external/${var.app_name}-keycloak_cso_secret-${var.environment}" |
Contributor
There was a problem hiding this comment.
Suggested change
| name = "external/${var.app_name}-keycloak_cso_secret-${var.environment}" | |
| name = "external/${var.app_name}-keycloak-cso-secret-${var.environment}" |
Just so its consistent with other secret names
devinleighsmith
force-pushed
the
JASPER-702
branch
from
b71a3f9 to
55e99dc
Compare
devinleighsmith
temporarily deployed
to
lz-dev
GitHub Actions
Inactive
|
JTraill
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for JIRA Ticket: ----JASPER-702----
Issue ticket number and link
https://jira.justice.gov.bc.ca/browse/JASPER-702
Description
Add service account oauth to JASPER CSO order upsert API endpoint.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested via postman. confirmed authentication, authorization on endpoint.
Test Configuration:
If applicable
Checklist:
Documentation References
Put any doc references here