Jasper 342 (P-Drive)

[devinleighsmith]

Pull Request for JIRA Ticket: ----jasper-342----

jasper-342 - jira.justice.gov.bc.ca/JASPER-342

Description

Introduces transitory documents api client/server and adds support to court file search. Currently gated by feature flag to reduce merge overhead.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested artificially against the Q: drive. Manually validated names of mappings in unexpected formats.
Validated that existing DARS, document functionality unaffected.
Confirmed that document search and opening Q drive documents functions as expected.
Tested against current Q: drive file structure.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-advanced-security]

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[sonarqubecloud]

Quality Gate failed

Failed conditions
7 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[devinleighsmith]

Recommend reviewing:

https://github.com/bcgov/jasper/pull/733/files/482576865ab47495edb537a86d0897e0b3035ca8..243ce8a6988fd7248545b4f336e4064a8cb801da

as the first commit of this PR is refactoring and cleanup, and contains a large number of files.

[ronaldo-macapobre]

I noticed the namespace sorting in the PR has "System" namespaces at the bottom. I've got a Visual Studio setting that sorts them at the top which is just a personal preference thing. Totally fine either way, but wanted to check what you guys prefer for consistency. I think if we turn it on and run the linting again, it might actually reduce the amount of code changes on this PR. I can adjust my settings on my end to match whatever we go with.