FOIMOD-4646: prevent deleted records from rejoining document sets

[alvesfc]

Summary

Fixes the FOI record delete flow so deleted records are actually removed from all document sets.

Root Cause

recordservice.update(...) was calling FOIRequestRecordGroups.remove_records_from_all_groups(...), but the loaded FOIRequestRecord.groups relationship was still attached to the ORM object. When FOIRequestRecord.create(...) later called db.session.merge(record), SQLAlchemy could merge that stale
relationship state back and recreate the join rows in FOIRequestRecordGroups.

Changes

• Clear loaded groups on records during the isdelete=True path before the merge-based save runs
• Add a regression test covering the delete flow and asserting stale group memberships are not carried into save

Files

• request_api/services/recordservice.py
• tests/services/test_recordservice.py

Verification

• pytest tests/services/test_recordservice.py -q

Notes

This keeps the existing transaction shape intact:

• record history is created
• records are soft-deleted
• document-set associations are removed
• Doc Reviewer API call still happens after DB commit

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud