Skip to content

Conversation

@ateucher
Copy link
Collaborator

@ateucher ateucher commented Mar 24, 2025

This small typo is leading to a CRAN check error in R devel due to modifying attributes of a primitive function: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-gcc/bcdata-00check.html.

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error ('test-cql-string.R:23:3'): bcdc_cql_string fails when used on an uncollected (promise) object ──
    Error in `attributes(.Data) <- c(attributes(.Data), attrib)`: Cannot modify attributes on primitive functions
    Backtrace:
        ▆
     1. ├─testthat::expect_error(...) at test-cql-string.R:23:3
     2. │ └─testthat:::expect_condition_matching(...)
     3. │   └─testthat:::quasi_capture(...)
     4. │     ├─testthat (local) .capture(...)
     5. │     │ └─base::withCallingHandlers(...)
     6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
     7. ├─bcdata:::bcdc_cql_string(structure(list, class = "bcdc_promise"))
     8. └─base::structure(list, class = "bcdc_promise")

Possibly the smallest change ever required for a new release

In R devel leading to error due to modifying attributes of a primitive function
@ateucher ateucher requested review from boshek and stephhazlitt March 24, 2025 19:09
@ateucher
Copy link
Collaborator Author

@boshek @stephhazlitt this is super basic so a review from just one of you would be lovely to just tick the box

Copy link
Collaborator

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ateucher ateucher merged commit c93f573 into main Mar 24, 2025
7 checks passed
@ateucher ateucher deleted the cran-error-primitive-attributes branch March 24, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants