feat(ui+api): added new registration sub-status column#1100
feat(ui+api): added new registration sub-status column#1100JazzarKarim merged 7 commits intobcgov:mainfrom
Conversation
| description: Local government (jurisdiction) filter | ||
| - in: query | ||
| name: renewalsOnly | ||
| name: reviewRenew |
There was a problem hiding this comment.
I renamed the query param to reviewReview to match the sub-status in the UI.
There was a problem hiding this comment.
ah, was wondering from above.
|
Temporary Url for review: https://strr-examiner-dev--pr-1100-ajw2kvnz.web.app |
|
Temporary Url for review: https://strr-examiner-dev--pr-1100-ajw2kvnz.web.app |
thorwolpert
left a comment
thorwolpert
left a comment
There was a problem hiding this comment.
nice, good to see it broken down a bit more too.
| description: Local government (jurisdiction) filter | ||
| - in: query | ||
| name: renewalsOnly | ||
| name: reviewRenew |
There was a problem hiding this comment.
ah, was wondering from above.
|
@JazzarKarim please rebase, since I merged the unit tests PR, just to make sure tests are passing and no conflicts. Thanks! |
JazzarKarim
force-pushed
the
1089-add-substatus-column
branch
from
b1d6d03 to
76c0430
Compare
|
Temporary Url for review: https://strr-examiner-dev--pr-1100-ajw2kvnz.web.app |
Just had to fix one test. Otherwise, tests are all passing, sweet! |
|
|
Temporary Url for review: https://strr-examiner-dev--pr-1100-ajw2kvnz.web.app |
4 participants
Issue:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License