Skip to content

#5905 - Bump docker-updates group across 6 directories#5920

Merged
sh16011993 merged 8 commits intomainfrom
feature/bump-docker-updates-group-across-directories
Mar 17, 2026
Merged

#5905 - Bump docker-updates group across 6 directories#5920
sh16011993 merged 8 commits intomainfrom
feature/bump-docker-updates-group-across-directories

Conversation

@sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Mar 17, 2026

As a part of this PR, the following was completed:

Bumped the docker-updates group with 1 update in the /sources/packages/backend/apps/api directory: node.
Bumped the docker-updates group with 1 update in the /sources/packages/backend/apps/load-test-gateway directory: node.
Bumped the docker-updates group with 1 update in the /sources/packages/backend/apps/queue-consumers directory: node.
Bumped the docker-updates group with 1 update in the /sources/packages/backend/apps/workers directory: node.
Bumped the docker-updates group with 1 update in the /sources/packages/backend/apps/db-migrations directory: node.
Bumped the docker-updates group with 1 update in the /sources/packages/web directory: node.

Copilot AI review requested due to automatic review settings March 17, 2026 17:56
@sh16011993 sh16011993 self-assigned this Mar 17, 2026
@sh16011993 sh16011993 added Dependencies Pull requests that update a dependency file Docker Docker-related PRs, for instance, Docker updates generated by depenabot. labels Mar 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Node.js base images used by several service/container builds in the monorepo, aligning Dockerfiles to reference the internal artifact registry while adding Dependabot hints for upstream image tracking.

Changes:

  • Bump Node base image from 25.6.1-alpine3.22 to 25.8.1-alpine3.22 in multiple Dockerfiles.
  • Replace DOCKER_REGISTRY build-arg indirection with explicit artifacts.developer.gov.bc.ca/docker-remote/... image references.
  • Add # dependabot: FROM ... hints to support automated base image version updates.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sources/packages/web/Dockerfile Updates builder base image to Node 25.8.1 and hard-codes the internal registry reference with a Dependabot hint.
sources/packages/backend/migrations/Dockerfile Updates Node base image to 25.8.1 and adds Dependabot hint while hard-coding internal registry.
sources/packages/backend/apps/workers/Dockerfile Updates Node base image to 25.8.1 and adds Dependabot hint while hard-coding internal registry.
sources/packages/backend/apps/queue-consumers/Dockerfile Updates Node base image to 25.8.1 and adds Dependabot hint while hard-coding internal registry.
sources/packages/backend/apps/load-test-gateway/Dockerfile Updates Node base image to 25.8.1 and adds Dependabot hint while hard-coding internal registry.
sources/packages/backend/apps/api/Dockerfile Updates Node base image to 25.8.1 and adds Dependabot hint while hard-coding internal registry.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +1 to +3
# Base Image
# dependabot: FROM node:25.8.1-alpine3.22
FROM artifacts.developer.gov.bc.ca/docker-remote/node:25.8.1-alpine3.22 AS builder
sh16011993 and others added 7 commits March 17, 2026 11:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Using ARG
…p-across-directories' into feature/bump-docker-updates-group-across-directories
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

@github-actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 20.18% ( 4568 / 22633 )
Methods: 9.52% ( 262 / 2753 )
Lines: 24.53% ( 3920 / 15982 )
Branches: 9.9% ( 386 / 3898 )

@github-actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 48.61% ( 2712 / 5579 )
Methods: 38.57% ( 285 / 739 )
Lines: 55.39% ( 2049 / 3699 )
Branches: 33.13% ( 378 / 1141 )

@github-actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 79.6% ( 9155 / 11501 )
Methods: 78.79% ( 1181 / 1499 )
Lines: 82.83% ( 6881 / 8307 )
Branches: 64.48% ( 1093 / 1695 )

@github-actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 64.69% ( 12747 / 19704 )
Methods: 61.18% ( 1489 / 2434 )
Lines: 68.45% ( 9291 / 13573 )
Branches: 53.21% ( 1967 / 3697 )

# Base Image
ARG DOCKER_REGISTRY=artifacts.developer.gov.bc.ca/docker-remote/
FROM ${DOCKER_REGISTRY}node:25.6.1-alpine3.22
# dependabot: FROM node:25.8.1-alpine3.22
Copy link
Collaborator

@dheepak-aot dheepak-aot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason to put the comment back? same in all files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an existing comment. I left it as it is.

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Asked for clarification on adding the comment again.

@sh16011993 sh16011993 merged commit 13e4797 into main Mar 17, 2026
21 of 22 checks passed
@sh16011993 sh16011993 deleted the feature/bump-docker-updates-group-across-directories branch March 17, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file Docker Docker-related PRs, for instance, Docker updates generated by depenabot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants