#5845 - Make institution location code optional by tiago-graf · Pull Request #5900 · bcgov/SIMS

tiago-graf · 2026-03-16T01:01:14Z

Summary

Make institution location code to make location optional on location edit form.
Adds validation to approve designation modal to block approval on locations without code.

Copilot

Pull request overview

Updates institution location handling to allow missing location codes during location maintenance while preventing designation approval of locations that do not yet have a code.

Changes:

Makes institutionCode nullable/optional across backend entity/service/models and key web DTOs, and updates the Form.io “institutionLocation” form with an explicit “no code” flow.
Extends AEST designation workflow data to include institutionCode per location and adds UI validation to block approving locations without a code.
Performs template prop/event casing cleanup in several Vue components.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sources/packages/web/src/views/institution/AddInstitutionLocation.vue	Prop/event casing updates for header and submit UI.
sources/packages/web/src/views/aest/institution/DesignationAESTView.vue	Adds `institutionCode` to designation approval location items.
sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts	Adjusts web DTOs to support optional code / “no code” flag.
sources/packages/web/src/services/http/dto/DesignationAgreement.dto.ts	Replaces `any` with `unknown` and formatting cleanup.
sources/packages/web/src/components/partial-view/DesignationAgreement/DesignationAgreementForm.models.ts	Adds optional `institutionCode` to location list model.
sources/packages/web/src/components/aest/institution/modals/ApproveDenyDesignationModal.vue	Displays location code and blocks approving locations with missing code.
sources/packages/forms/src/form-definitions/institutionlocation.json	Makes code optional with checkbox + conditional validation + banner.
sources/packages/forms/package-lock.json	Lockfile updates (peer metadata).
sources/packages/backend/libs/sims-db/src/entities/institution-location.model.ts	Makes `institutionCode` nullable at the ORM level.
sources/packages/backend/apps/api/src/services/institution-location/institution-location.service.ts	Skips duplicate checks when code is absent; persists null when no code.
sources/packages/backend/apps/api/src/services/institution-location/institution-location.models.ts	Makes `institutionCode` optional and introduces `noInstitutionCode` flag.
sources/packages/backend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts	Allows optional input code; adjusts output typing for nullable codes.

Files not reviewed (1)

sources/packages/forms/package-lock.json: Language not supported

Comments suppressed due to low confidence (2)

sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts:47

InstitutionLocationAPIInDTO still declares institutionCode as a required string, but the location code is now optional (and the backend AEST DTO accepts string | null). This forces callers to fabricate empty strings and makes the contract inconsistent; update the DTO to accept institutionCode?: string | null (and consider exposing noInstitutionCode if the form submits it).

export class InstitutionLocationAPIInDTO
  implements AddressDetailsFormAPIDTO, InstitutionLocationPrimaryContactAPIInDTO
{
  @Expose()
  locationName: string;
  @Expose()
  institutionCode: string;
  // From InstitutionLocationPrimaryContactAPIInDTO.

sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts:86

InstitutionLocationFormAPIOutDTO still requires institutionCode: string, but the form can now legitimately represent a location without a code. This will make formData typing inaccurate and can cause downstream code to assume a value exists; update it to institutionCode?: string | null (and optionally include noInstitutionCode?: boolean for round-tripping).

export interface InstitutionLocationFormAPIOutDTO extends AddressDetailsFormAPIDTO {
  locationName: string;
  institutionCode: string;
  primaryContactFirstName: string;
  primaryContactLastName: string;
  primaryContactEmail: string;
  primaryContactPhone: string;
}

You can also share your feedback on Copilot code review. Take the survey.

sources/packages/web/src/components/aest/institution/modals/ApproveDenyDesignationModal.vue

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

tiago-graf · 2026-03-16T17:11:18Z

sources/packages/forms/src/form-definitions/institutionlocation.json

+              "value": ""
+            }
+          ],
+          "content": "<strong class=\"ml-2\">Missing institution location code</strong><br><span>Please note: You will be able to create this location without an institution location code. However, you will not be able to designate this location until you obtain a federally issued code from StudentAid BC. Once you submit your location please email designat@gov.bc.ca and request they provide you with the code and update the location information.</span>",


Confirmed with @Joshua-Lakusta that this email is accurate

Copilot

Pull request overview

Updates institution location handling across the stack to allow saving locations without an institution location code, while preventing designation approvals for locations that do not have a code.

Changes:

Make Institution Location Code optional in the institution Form.io form (adds “no code” checkbox + warning banner + conditional validation/disable).
Update backend persistence to allow nullable institution_code, adjust duplicate checks, and add validation to block approving designations for approved locations without a code.
Propagate optional code through web/AEST views and add new API e2e coverage for AEST location get/update and designation agreement update.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
sources/packages/web/src/views/institution/AddInstitutionLocation.vue	Template prop casing adjustments for consistency (kebab-case).
sources/packages/web/src/views/aest/institution/DesignationAESTView.vue	Includes institutionCode in the designation locations model for modal display/validation.
sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts	Adds `noInstitutionCode` to input DTOs and makes location code optional in some outputs.
sources/packages/web/src/services/http/dto/DesignationAgreement.dto.ts	Tightens typing (`any` → `unknown`) and formatting.
sources/packages/web/src/components/partial-view/DesignationAgreement/DesignationAgreementForm.models.ts	Extends designation location list item to include optional institutionCode.
sources/packages/web/src/components/aest/institution/modals/ApproveDenyDesignationModal.vue	Blocks approving a location without a code in the AEST modal UI and updates modal typing.
sources/packages/forms/src/form-definitions/institutionlocation.json	Makes code conditionally required and adds “no code” checkbox + warning banner.
sources/packages/forms/package-lock.json	Lockfile metadata updates.
sources/packages/backend/libs/sims-db/src/entities/institution-location.model.ts	Marks `institution_code` as nullable in the entity.
sources/packages/backend/apps/api/src/services/institution-location/institution-location.service.ts	Trims code, conditionally checks duplicates, and adds validation helper for designation approval.
sources/packages/backend/apps/api/src/services/institution-location/institution-location.models.ts	Makes institutionCode optional in the service model and adds `noInstitutionCode`.
sources/packages/backend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts	Updates DTO validation/typing to allow null/optional institution codes.
sources/packages/backend/apps/api/src/route-controllers/institution-locations/tests/e2e/institution-location.aest.controller.update.e2e-spec.ts	New e2e coverage for updating with empty code and duplicate code validation.
sources/packages/backend/apps/api/src/route-controllers/institution-locations/tests/e2e/institution-location.aest.controller.getInstitutionLocation.e2e-spec.ts	New e2e coverage ensuring null vs present institutionCode in responses.
sources/packages/backend/apps/api/src/route-controllers/designation-agreement/designation-agreement.aest.controller.ts	Enforces institution code presence for approved locations (unprocessable entity with typed error).
sources/packages/backend/apps/api/src/route-controllers/designation-agreement/tests/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts	New e2e coverage for designation approval/decline and missing-code rejection.
sources/packages/backend/apps/api/src/constants/error-code.constants.ts	Adds new error code `MISSING_INSTITUTION_LOCATION_CODE`.

Files not reviewed (1)

sources/packages/forms/package-lock.json: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts

sources/packages/backend/libs/sims-db/src/entities/institution-location.model.ts

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

sources/packages/forms/src/form-definitions/institutionlocation.json

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-03-17T18:10:48Z

E2E SIMS API Coverage Report

Totals
Statements:	65.2% ( 12867 / 19736 )
Methods:	61.8% ( 1506 / 2437 )
Lines:	68.96% ( 9372 / 13590 )
Branches:	53.63% ( 1989 / 3709 )

dheepak-aot · 2026-03-17T18:49:20Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+
+  it("Should approve a designation agreement when all payload locations belong to the institution.", async () => {
+    // Arrange
+    const { institution } = await getAuthRelatedEntities(


We don't have to get the data-seeded institution here. We can have a new institution created this way.

const institution = await db.institution.save(createFakeInstitution());

dheepak-aot · 2026-03-17T19:09:00Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+    const updatedDesignation = await db.designationAgreement.findOneBy({
+      id: savedDesignation.id,
+    });
+    expect(updatedDesignation.designationStatus).toBe(
+      DesignationAgreementStatus.Approved,
+    );
+  });


At least for one test we can assert the possible updated fields.

const updatedDesignation = await db.designationAgreement.findOne({ select: { id: true, designationStatus: true, startDate: true, endDate: true, designationAgreementLocations: { id: true, institutionLocation: { id: true }, approved: true, }, institution: { id: true, notes: { id: true, noteType: true, description: true }, }, assessedBy: { id: true }, assessedDate: true, }, relations: { designationAgreementLocations: { institutionLocation: true }, institution: { notes: true }, assessedBy: true, }, where: { id: savedDesignation.id }, loadEagerRelations: false, }); const auditUser = await getAESTUser( db.dataSource, AESTGroups.BusinessAdministrators, ); expect(updatedDesignation.designationStatus).toEqual({ id: savedDesignation.id, designationStatus: DesignationAgreementStatus.Approved, startDate: "2026-01-01", endDate: "2027-12-31", designationAgreementLocations: [ { id: expect.any(Number), institutionLocation: { id: savedLocation.id }, approved: true, }, ], institution: { id: institution.id, notes: [ { id: expect.any(Number), noteType: NoteType.Designation, description: "Designation approved.", }, ], }, assessedBy: { id: auditUser.id }, assessedDate: expect.any(Date), });

dheepak-aot · 2026-03-17T19:11:12Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+
+  it("Should decline a designation agreement.", async () => {
+    // Arrange
+    const { institution } = await getAuthRelatedEntities(


https://github.com/bcgov/SIMS/pull/5900/changes#r2948872035

dheepak-aot · 2026-03-17T19:12:41Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+        designationStatus: DesignationAgreementStatus.Declined,
+        note: "Some note.",
+      })
+      .expect(HttpStatus.NOT_FOUND);


Can we assert the whole response similar to this.

dheepak-aot · 2026-03-17T19:15:56Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+      await db.designationAgreement.save(fakeDesignation);
+    // Create a location that belongs to a different institution.
+    const unrelatedLocation = createFakeInstitutionLocation();
+    const savedUnrelatedLocation =


Minor, when await db.institutionLocation.save(unrelatedLocation); is executed the unrelatedLocation is updated automatically and not required to re-assign to a new const.

dheepak-aot · 2026-03-17T19:16:37Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+        ],
+        note: "Attempt with unrelated location.",
+      })
+      .expect(HttpStatus.UNPROCESSABLE_ENTITY);


Please assert the complete response.

dheepak-aot · 2026-03-17T19:18:09Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+    const fakeLocation = createFakeInstitutionLocation({ institution });
+    fakeLocation.institutionCode = null;
+    const savedLocation = await db.institutionLocation.save(fakeLocation);
+    const fakeUser = await db.user.save(createFakeUser());


If fake user is required across many tests, we can have one created globally for that sake.

dheepak-aot · 2026-03-17T19:20:02Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+      fakeInstitutionLocations: [savedLocation],
+      fakeUser,
+    });
+    fakeDesignation.designationStatus = DesignationAgreementStatus.Pending;


To set the designationStatus we can use the initialValues in factory.

const fakeDesignation = createFakeDesignationAgreement( { fakeInstitution: institution, fakeInstitutionLocations: [savedLocation], fakeUser, }, { initialValue: { designationStatus: DesignationAgreementStatus.Pending }, }, );

dheepak-aot · 2026-03-17T19:23:31Z

...ent/_tests_/e2e/designation-agreement.aest.controller.updateDesignationAgreement.e2e-spec.ts

+      })
+      .expect(HttpStatus.UNPROCESSABLE_ENTITY)
+      .expect({
+        message:


Thanks for creating the E2E tests with good coverage.

dheepak-aot · 2026-03-17T19:42:14Z

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

+   * @param locationIds location IDs to validate.
+   * @returns true when all locations have a non-null institution location code.
+   */
+  async validateLocationsHaveInstitutionCode(


If our intention was to see if there is any location without code, we can check for the opposite.

async hasAnyLocationWithoutCode(locationIds: number[]): Promise<boolean> { const locationWithoutCode = await this.repo .createQueryBuilder("location") .select("1") .where("location.id IN (:...locationIds)", { locationIds }) .andWhere("location.institutionCode IS NULL") .limit(1) .getRawOne(); return !!locationWithoutCode; }

dheepak-aot · 2026-03-17T19:46:06Z

...pps/api/src/route-controllers/designation-agreement/designation-agreement.aest.controller.ts

+      const approvedLocationIds = payload.locationsDesignations
+        .filter((location) => location.approved)
+        .map((location) => location.locationId);
+      if (approvedLocationIds.length > 0) {


Based on the suggestion from the comment, https://github.com/bcgov/SIMS/pull/5900/changes#r2949170341 this condition won't be required.

dheepak-aot · 2026-03-17T20:32:06Z

...pps/api/src/route-controllers/designation-agreement/designation-agreement.aest.controller.ts

+              "One or more approved locations are missing an institution location code.",
+              MISSING_INSTITUTION_LOCATION_CODE,


Does it need to be an API Process error? We use API process error to show a different error message other than the generic one (e.g. unexpected error when approving/declining the designation).

dheepak-aot · 2026-03-17T20:33:30Z

...ocations/_tests_/e2e/institution-location.aest.controller.getInstitutionLocation.e2e-spec.ts

+    expect(response.body.institutionCode).toBeNull();
+  });
+
+  it("Should return institution location with the institution code when one is assigned.", async () => {


For one of the tests, can we assert the complete payload?

dheepak-aot · 2026-03-17T20:36:45Z

...rs/institution-locations/_tests_/e2e/institution-location.aest.controller.update.e2e-spec.ts

+    db = createE2EDataSources(dataSource);
+  });
+
+  it("Should save institution location with null code when an empty institution code is submitted.", async () => {


As per business requirement, the ministry should not be able to save the institution location as NULL.

dheepak-aot · 2026-03-17T20:38:58Z

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts

-  @IsNotEmpty()
-  institutionCode: string;
+  @IsOptional()
+  institutionCode?: string | null;


institutionCode?: string; should be good enough.

dheepak-aot · 2026-03-17T20:39:48Z

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts

 export class InstitutionLocationDetailsAPIOutDTO extends AddressDetailsAPIOutDTO {
  locationName: string;
-  institutionCode: string;
+  institutionCode: string | null;


institutionCode?: string ?

Same in other places.

dheepak-aot · 2026-03-17T20:42:59Z

...kend/apps/api/src/route-controllers/institution-locations/models/institution-location.dto.ts

  @Allow()
  institutionCode: string;
  @Allow()
+  noInstitutionCode?: boolean;


Is the boolean value not suppose to be present always?

dheepak-aot · 2026-03-17T20:48:07Z

...s/packages/backend/apps/api/src/services/institution-location/institution-location.models.ts

  locationName: string;
-  institutionCode: string;
+  institutionCode?: string;
+  noInstitutionCode?: boolean;


InstitutionLocationModel is used for update location. The update location operation is ministry specific and ministry isn't expected to either see the checkbox or use the checkbox. Hence these model updates aren't relevant.

For Update can use a model derived from InstitutionLocationModel.

export type InstitutionLocationUpdateModel = Omit< InstitutionLocationModel, "noInstitutionCode" > & { institutionCode: string; };

dheepak-aot · 2026-03-17T20:54:49Z

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

      },
      institution: institution,
-      institutionCode: data.institutionCode,
+      institutionCode: hasInstitutionCode ? normalizedInstitutionCode : null,


institutionCode: normalizedInstitutionCode, should be good enough

dheepak-aot · 2026-03-17T20:56:30Z

.../packages/backend/apps/api/src/services/institution-location/institution-location.service.ts

+    const hasInstitutionCode =
+      !!institutionLocationData.institutionCode?.trim();
+    const normalizedInstitutionCode = hasInstitutionCode
+      ? institutionLocationData.institutionCode.trim()
+      : null;


During update location, location code must be present.

dheepak-aot · 2026-03-17T20:59:51Z

sources/packages/backend/libs/sims-db/src/entities/institution-location.model.ts

+    nullable: true,
  })
-  institutionCode: string;
+  institutionCode: string | null;


institutionCode?: string;

dheepak-aot · 2026-03-17T21:09:07Z

sources/packages/forms/src/form-definitions/institutionlocation.json

+              "value": ""
+            }
+          ],
+          "content": "<strong class=\"ml-2\">Missing institution location code</strong><br><span>Please note: You will be able to create this location without an institution location code. However, you will not be able to designate this location until you obtain a federally issued code from StudentAid BC. Once you submit your location please email designat@gov.bc.ca and request they provide you with the code and update the location information.</span>",


Please match the warning banner styling as per our other warning banners.

e.g.

dheepak-aot · 2026-03-17T21:13:37Z

sources/packages/forms/src/form-definitions/institutionlocation.json

            "minLength": 4,
            "maxLength": 4,
-            "pattern": "[A-Z]*"
+            "pattern": "[A-Z]*",


The institution location read-only view is not reflecting the right state of the data.

It can be candled by API returning the boolean property based on presence of location code.

dheepak-aot · 2026-03-17T21:21:19Z

sources/packages/forms/src/form-definitions/institutionlocation.json

+            "pattern": "[A-Z]*",
+            "custom": "valid = (!data.noInstitutionCode && !input) ? 'Institution location code is required.' : true;"
          },
+          "logic": [


Here are the business expectations for the institution location code as per my understanding.

The institution location code is not a mandatory field only if the new checkbox is selected and if the checkbox is not selected, then it is still a required field. This action is only applicable for Institutions create a new location and NOT for ministry editing/updating a location.(Note: Institution create/view location, Ministry update location share the same form)

When ministry update institution location code, the institution location is a required field and checkbox must not be visible for ministry user.

dheepak-aot · 2026-03-17T21:24:18Z

sources/packages/forms/src/form-definitions/institutionlocation.json

+          "defaultValue": false,
+          "key": "noInstitutionCode",
+          "attributes": {
+            "data-cy": "noInstitutionCode"


data-cy is not relevant anymore.

dheepak-aot · 2026-03-17T21:25:53Z

sources/packages/forms/src/form-definitions/institutionlocation.json

+          "refreshOnChange": true,
+          "hidden": true,
+          "key": "noInstitutionCodeBanner",
+          "customConditional": "show = data.noInstitutionCode === true;",


Please use a simple condition.

dheepak-aot · 2026-03-17T21:29:42Z

sources/packages/web/src/services/http/dto/InstitutionLocation.dto.ts

@@ -15,6 +15,8 @@ export class InstitutionLocationFormAPIInDTO extends AddressDetailsFormAPIDTO {
  @Expose()
  institutionCode: string;


institutionCode?: string;

dheepak-aot · 2026-03-17T21:30:03Z

sources/packages/web/src/services/http/dto/DesignationAgreement.dto.ts

  startDate: string;
  endDate: string;
-  submittedData: any;
+  submittedData: unknown;


dheepak-aot · 2026-03-17T21:31:09Z

sources/packages/forms/package-lock.json

      "integrity": "sha512-jl1vZzPDinLr9eUt3J/t7V6FgNEw9QjvBPdysz9KfQDD41fQrC2Y4vKQdiaUpFT4bXlb1RHhLpp8wtm6M5TgSw==",
-      "dev": true
+      "dev": true,
+      "peer": true


Is it due to the node update?

I'm probably using a different node version, anyway, i'm reverting the changes

dheepak-aot · 2026-03-17T21:33:54Z

sources/packages/web/src/components/aest/institution/modals/ApproveDenyDesignationModal.vue

+            </v-row>
+            <v-row v-if="item.approved && !item.institutionCode" class="mt-0">
+              <v-col class="text-right pt-0">
+                <span class="text-error d-block"


We already show the validation errors at 1. Is there a need to show additionally at 2. ?

I was following the wireframes, happy to remove

dheepak-aot · 2026-03-17T21:35:06Z

Nice work @tiago-graf. Please take a look at the comments.

sonarqubecloud · 2026-03-18T05:51:08Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-18T05:51:39Z

Backend Unit Tests Coverage Report

Totals
Statements:	20.17% ( 4568 / 22644 )
Methods:	9.51% ( 262 / 2754 )
Lines:	24.52% ( 3920 / 15988 )
Branches:	9.89% ( 386 / 3902 )

github-actions · 2026-03-18T05:51:57Z

E2E Workflow Workers Coverage Report

Totals
Statements:	48.61% ( 2712 / 5579 )
Methods:	38.57% ( 285 / 739 )
Lines:	55.39% ( 2049 / 3699 )
Branches:	33.13% ( 378 / 1141 )

github-actions · 2026-03-18T05:54:46Z

E2E Queue Consumers Coverage Report

Totals
Statements:	79.6% ( 9155 / 11501 )
Methods:	78.79% ( 1181 / 1499 )
Lines:	82.83% ( 6881 / 8307 )
Branches:	64.48% ( 1093 / 1695 )

Make location code optional

920ca4a

tiago-graf self-assigned this Mar 16, 2026

tiago-graf requested a review from Copilot March 16, 2026 01:02

Copilot started reviewing on behalf of tiago-graf March 16, 2026 01:03 View session

tiago-graf added Form.io Form IO definitions changed. Web portal Backend Used by the dependabot pull requests to identify PRs related to the backend. labels Mar 16, 2026

Copilot AI reviewed Mar 16, 2026

View reviewed changes

tiago-graf added 3 commits March 15, 2026 18:31

Added e2e tests

1e9b902

Fix e2e test

ea1cfd8

PR comments

5adcbf0

tiago-graf commented Mar 16, 2026

View reviewed changes

tiago-graf requested a review from Copilot March 16, 2026 17:11

Copilot started reviewing on behalf of tiago-graf March 16, 2026 17:12 View session

Copilot AI reviewed Mar 16, 2026

View reviewed changes

tiago-graf and others added 3 commits March 16, 2026 10:44

Potential fix for pull request finding

de0af9e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update institution-location.service.ts

d31d287

Updated institutionCode type

2b5e2b6

tiago-graf marked this pull request as ready for review March 17, 2026 17:24

dheepak-aot self-requested a review March 17, 2026 17:54

Update ApproveDenyDesignationModal.vue

5c44b04

dheepak-aot reviewed Mar 17, 2026

View reviewed changes

dheepak-aot added E2E/Unit tests labels Mar 17, 2026

dheepak-aot reviewed Mar 17, 2026

View reviewed changes

Update PR Comments

fee3664

		"One or more approved locations are missing an institution location code.",
		MISSING_INSTITUTION_LOCATION_CODE,

		@@ -15,6 +15,8 @@ export class InstitutionLocationFormAPIInDTO extends AddressDetailsFormAPIDTO {
		@Expose()
		institutionCode: string;

Conversation

tiago-graf commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

E2E SIMS API Coverage Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dheepak-aot Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dheepak-aot Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dheepak-aot Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiago-graf commented Mar 16, 2026 •

edited

Loading

dheepak-aot Mar 17, 2026 •

edited

Loading

dheepak-aot Mar 17, 2026 •

edited

Loading

dheepak-aot Mar 17, 2026 •

edited

Loading