Skip to content

Refactoring mail service#17

Merged
saravanpa-aot merged 6 commits intomainfrom
dev-fix
Mar 13, 2026
Merged

Refactoring mail service#17
saravanpa-aot merged 6 commits intomainfrom
dev-fix

Conversation

@saravanpa-aot
Copy link
Collaborator

@saravanpa-aot saravanpa-aot commented Mar 13, 2026

It started while i was checking why submit mails were failing ..the reason was proponent moved out of project table ..When testing that fix , I realised in submit->common mail migration , there is a few things which were missing..so fixed them up and also improved the directory structure a bit

Changes

  • added a shared EmailDetails dataclass inside epic_cron
  • moved email templates into packaged locations under src/epic_cron/templates/submit and src/epic_cron/templates/centre..this is the major looking change.. For that introduced domain
  • some refactoring on chesservice
  • added non-prod environment banners for both submit and centre emails
  • added a debug log after successful CHES sends showing to, subject, from, and response status
  • added the fix for proponent fetch from correct able

@saravanpa-aot saravanpa-aot changed the title change for Proponent name from the correct table Refactoring mail service Mar 13, 2026
Copy link
Collaborator

@leodube-aot leodube-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Is there anything that can be cleaned up in the EPIC.submit repo once this is merged? Looks like the data_classes folder (and maybe templates folder?) have been brought over and are no longer imported from submit. Maybe something that could be included in the refactor ticket SUBMIT-719 coming up?

@saravanpa-aot
Copy link
Collaborator Author

Looks good!

Is there anything that can be cleaned up in the EPIC.submit repo once this is merged? Looks like the data_classes folder (and maybe templates folder?) have been brought over and are no longer imported from submit. Maybe something that could be included in the refactor ticket SUBMIT-719 coming up?

yup.. Needs a follow up ticket .. I will create one

@saravanpa-aot saravanpa-aot merged commit 6f9198e into main Mar 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants