Merged
Conversation
nitheesh-aot
approved these changes
Mar 13, 2026
leodube-aot
approved these changes
Mar 13, 2026
Collaborator
There was a problem hiding this comment.
Looks good!
Is there anything that can be cleaned up in the EPIC.submit repo once this is merged? Looks like the data_classes folder (and maybe templates folder?) have been brought over and are no longer imported from submit. Maybe something that could be included in the refactor ticket SUBMIT-719 coming up?
Collaborator
Author
yup.. Needs a follow up ticket .. I will create one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It started while i was checking why submit mails were failing ..the reason was proponent moved out of project table ..When testing that fix , I realised in submit->common mail migration , there is a few things which were missing..so fixed them up and also improved the directory structure a bit
Changes