Return HTTP 403 for blocked CONNECT requests to stop client retry storms#14
Merged
Return HTTP 403 for blocked CONNECT requests to stop client retry storms#14
Conversation
ConnectReject with no ctx.Resp caused a bare TCP close, which HTTP clients (npm, etc.) interpreted as a transient error and retried in a tight loop. Setting ctx.Resp to a 403 response gives clients a clear signal that the request was intentionally denied. Uses a generic message across all reject paths to avoid leaking policy details to the client. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectReject with no ctx.Resp caused a bare TCP close, which HTTP
clients (npm, etc.) interpreted as a transient error and retried in a
tight loop. Setting ctx.Resp to a 403 response gives clients a clear
signal that the request was intentionally denied. Uses a generic message
across all reject paths to avoid leaking policy details to the client.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com