PR to include client expiration#172
Open
fieldofsheep wants to merge 3 commits intobbernhard:masterfrom
Open
Conversation
bbernhard
reviewed
Nov 8, 2021
Owner
bbernhard
left a comment
bbernhard
left a comment
There was a problem hiding this comment.
Sorry, completely forgot to review your changes!
A few things I've noticed:
-
I think it would be better to rename
func (a *Api) Contact(c *gin.Context)tofunc (a *Api) UpdateContact(c *gin.Context)to make it clear that the function updates the contact information. -
As the request only updates the contact info, I think it would be better to use
PUTinstead ofPOST. -
At the moment (almost) all the endpoints use the plural form. So I think it would be better to change the endpoint to
/v1/contactsinstead of/v1/contact -
The JSON-RPC implementation is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on the last PR was too out of date with Merge Conflicts so I bedded in the changes. Linter must have cleaned some aspects of the file too. This encompasses #143