Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the “new navigation” rollout for an additional batch of World Service services by expanding the allowlist used when fetching navigation config, updating brand SVGs for those services, and adjusting Cypress/tests to reflect the rollout.
Changes:
- Expanded
SERVICES_WITH_NEW_NAVto include the next set of services in the rollout. - Updated multiple chameleon brand SVGs (primarily
viewboxtweaks and SVG path updates) for the newly enabled services. - Updated Cypress/test logic (mobile nav toggle service gating +
fetchConfigunit test fixture/service swap).
Reviewed changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| ws-nextjs-app/cypress/e2e/testsForAllCanonicalPages.ts | Removes Persian from the limited “mobile nav toggle” test service list. |
| ws-nextjs-app/cypress/e2e/testsForAllAMPPages.ts | Removes Persian from the limited “mobile nav toggle” test service list (AMP). |
| cypress/e2e/pages/testsForAllCanonicalPages.js | Removes Persian from the limited “mobile nav toggle” test service list (legacy Cypress suite). |
| cypress/e2e/pages/testsForAllAMPPages.js | Removes Persian from the limited “mobile nav toggle” test service list (legacy AMP suite). |
| src/app/components/Navigation/config.ts | Expands the SERVICES_WITH_NEW_NAV allowlist to include the next rollout services. |
| src/app/lib/utilities/fetchConfig/index.test.ts | Updates the “no useNewNav” test to use a service not in the allowlist after rollout expansion. |
| src/app/components/ThemeProvider/chameleonLogos/afaanoromoo.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/afrique.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/amharic.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/bengali.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/burmese.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/gahuza.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/hausa.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/igbo.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/indonesia.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/japanese.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/korean.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/marathi.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/nepali.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/persian.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/pidgin.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/polska.tsx | Updates brand SVG structure and viewbox (cropping/alignment). |
| src/app/components/ThemeProvider/chameleonLogos/portuguese.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/punjabi.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/romania.tsx | Reworks brand SVG structure and updates viewbox to match new composition. |
| src/app/components/ThemeProvider/chameleonLogos/somali.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/swahili.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/tamil.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/telugu.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/thai.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/tigrinya.tsx | Updates brand SVG viewbox for alignment/cropping. |
| src/app/components/ThemeProvider/chameleonLogos/turkce.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/ukrainian.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/vietnamese.tsx | Updates brand SVG and adds/adjusts viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/yoruba.tsx | Minor viewbox adjustment for alignment/cropping. |
LilyL0u
approved these changes
Apr 7, 2026
louisearchibald
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2441
Summary
Enables new navigation for Azeri, Brasil, Burmese, Dari, Indonesian, Japanese, Korean, Kyrgyz, Magyarul, Mundo, Nepali, Pashto, Persian, Polska, Romania, Russian, Sinhala, Vietnamese, Thai, Turkce and Ukrainian services
Code changes
Testing
http://localhost:7081/azeri?renderer_env=live
http://localhost:7081/portuguese?renderer_env=live
http://localhost:7081/burmese?renderer_env=live
http://localhost:7081/dari?renderer_env=live
http://localhost:7081/indonesia?renderer_env=live
http://localhost:7081/japanese?renderer_env=live
http://localhost:7081/korean?renderer_env=live
http://localhost:7081/kyrgyz?renderer_env=live
http://localhost:7081/magyarul?renderer_env=live
http://localhost:7081/mundo?renderer_env=live
http://localhost:7081/nepali?renderer_env=live
http://localhost:7081/pashto?renderer_env=live
http://localhost:7081/persian?renderer_env=live
http://localhost:7081/polska?renderer_env=live
http://localhost:7081/russian?renderer_env=live
http://localhost:7081/sinhala?renderer_env=live
http://localhost:7081/vietnamese?renderer_env=live
http://localhost:7081/thai?renderer_env=live
http://localhost:7081/turkce?renderer_env=live
http://localhost:7081/ukrainian?renderer_env=live
http://localhost:7081/romania?renderer_env=live
Useful Links