Skip to content

NOTICKET - Fix misspellings of 'separate' in docs #13877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EoinTrial wants to merge 1 commit into
base: latest
Choose a base branch
from
+2 −2
Open

NOTICKET - Fix misspellings of 'separate' in docs #13877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPENDABOT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ We chose to group all minor and patch updates for [loadable](https://github.com/

## Group BBC Non-Major Deps

We chose to [group updates to BBC packages](https://github.com/bbc/simorgh/blob/c17b20ef183e8bc94afb66d2414bc7e5ac14a845/.github/dependabot.yml#L14-L19) into one PR for minor and patch updates. Major package updates will generate seperate PRs as you would expect allowing you to bring them in seperately for the feature/breaking change you are introducing.
We chose to [group updates to BBC packages](https://github.com/bbc/simorgh/blob/c17b20ef183e8bc94afb66d2414bc7e5ac14a845/.github/dependabot.yml#L14-L19) into one PR for minor and patch updates. Major package updates will generate separate PRs as you would expect allowing you to bring them in separately for the feature/breaking change you are introducing.


## Ignored Dependencies
Expand Down
2 changes: 1 addition & 1 deletion docs/Coding-Standards/Migrating-Legacy-Components.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const MyComponent = ({ prop1 }: MyComponentProps) => {
}
```

## ⚠️ When not to declare types/interfaces in a seperate `types.ts` file
## ⚠️ When not to declare types/interfaces in a separate `types.ts` file

Usually if it makes more sense to keep the type/interface declaration right next to the component if it is not required or used anywhere else.

Expand Down
Loading