Skip to content

Revert "TEMP: Skip media player e2e tests on Local/Test env" #13856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amoore108 wants to merge 3 commits into
base: latest
Choose a base branch
from
+3 −15
Draft

Revert "TEMP: Skip media player e2e tests on Local/Test env" #13856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b5f03f
Revert "TEMP: Skip media player e2e tests on Local/Test env (#13854)"
amoore108 Mar 31, 2026
a9bfee7
Merge branch 'latest' into revert-13854-NOTICKET-temp-skip-media-play…
amoore108 Apr 1, 2026
fe75e75
Merge branch 'latest' into revert-13854-NOTICKET-temp-skip-media-play…
amoore108 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ws-nextjs-app/cypress/e2e/articlePage/testsForAMPOnly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Services } from '#app/models/types/global';
import getAppEnv from '#cypress/support/helpers/getAppEnv';
import skipOnLocal from '../../support/helpers/skipOnLocal';
import { ServiceParametersType } from '../../types';
import { ampOnly as crossPlatform } from '../assertions/crossPlatformAssertion';
Expand Down Expand Up @@ -46,10 +45,7 @@ export default ({
}
});

// TODO: Remove once Test env assets are fixed
const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe;

describeOrSkip('Media Player: AMP', () => {
describe('Media Player: AMP', () => {
it('should render an iframe with a valid URL', () => {
if (articleHasPlayer(articleId)) {
cy.get('[data-e2e="media-player"]').should('be.visible');
Expand Down
6 changes: 1 addition & 5 deletions ws-nextjs-app/cypress/e2e/articlePage/testsForCanonicalOnly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
AresMediaMetadataBlock,
CaptionBlock,
} from '#app/components/MediaLoader/types';
import getAppEnv from '#cypress/support/helpers/getAppEnv';
import { ServiceParametersType } from '../../types';
import { getBlockData, getBlockByType, getVideoEmbedUrl } from './helpers';
import runIfToggleEnabled from '../../support/helpers/runIfToggleEnabled';
Expand Down Expand Up @@ -102,10 +101,7 @@ export default ({
cy.go('back');
});

// TODO: Remove once Test env assets are fixed
const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe;

describeOrSkip('Media Player: Canonical', () => {
describe('Media Player: Canonical', () => {
it('should render a visible placeholder image', () => {
cy.window()
.getPageDataFromWindow()
Expand Down
6 changes: 1 addition & 5 deletions ws-nextjs-app/cypress/e2e/mediaAssetPage/testsForAMPOnly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
import getAppEnv from '#cypress/support/helpers/getAppEnv';
import { ServiceParametersType } from '../../types';

// For testing features that may differ across services but share a common logic e.g. translated strings.
export default ({ service, pageType, path }: ServiceParametersType) => {
describe(`AMP tests for ${service} ${pageType} ${path}`, () => {
// TODO: Remove once Test env assets are fixed
const describeOrSkip = getAppEnv() !== 'live' ? describe.skip : describe;

describeOrSkip('Media Player', () => {
describe('Media Player', () => {
it('should render an iframe with a valid URL', () => {
if (!`${Cypress.env('currentPath')}`.includes('/russian/av/')) {
cy.get(`amp-iframe`).should('be.visible');
Expand Down
Loading