facade: fix file descriptor leak during comms errors#66
Open
andrewbonney wants to merge 1 commit intomasterfrom
Open
facade: fix file descriptor leak during comms errors#66andrewbonney wants to merge 1 commit intomasterfrom
andrewbonney wants to merge 1 commit intomasterfrom
Conversation
andrewbonney
force-pushed
the
andrewbo-fd
branch
from
d0b3900 to
911e203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm mostly putting this here for safe keeping. I wrote this whilst tracking down a bug which had already been fixed, however this may well catch an additional potential FD leak. I'll come back to it if required.