Upstream: Update the API of swift_common.compile_module_interface.#1527
Closed
luispadron wants to merge 2 commits intomainfrom
Closed
Upstream: Update the API of swift_common.compile_module_interface.#1527luispadron wants to merge 2 commits intomainfrom
swift_common.compile_module_interface.#1527luispadron wants to merge 2 commits intomainfrom
Conversation
This adds the `target_name` argument that is present in other compile APIs so that supplemental outputs can get unique names based on the name of the Bazel target being compiled (will be used in a follow-up change). Likewise, this changes the return type of the function from just the module context to a `struct` that contains two fields: `module_context` (the original value), and `supplemental_outputs`, which will eventually be used to provide an indexstore (supported starting from Swift 6.2/Xcode 16.3). PiperOrigin-RevId: 741516048
luispadron
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
referenced
this pull request
May 29, 2025
This adds the `target_name` argument that is present in other compile APIs so that supplemental outputs can get unique names based on the name of the Bazel target being compiled (will be used in a follow-up change). Likewise, this changes the return type of the function from just the module context to a `struct` that contains two fields: `module_context` (the original value), and `supplemental_outputs`, which will eventually be used to provide an indexstore (supported starting from Swift 6.2/Xcode 16.3). PiperOrigin-RevId: 741516048
Contributor
Author
|
Moving to draft until we can take: 81c5b92 Which requires updates to the worker code. |
aaronsky
approved these changes
Jun 4, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick: 4c41849
This adds the
target_nameargument that is present in other compile APIs so that supplemental outputs can get unique names based on the name of the Bazel target being compiled (will be used in a follow-up change).Likewise, this changes the return type of the function from just the module context to a
structthat contains two fields:module_context(the original value), andsupplemental_outputs, which will eventually be used to provide an indexstore (supported starting from Swift 6.2/Xcode 16.3).PiperOrigin-RevId: 741516048