feat(bzlmod): Add rust_toolchain_file attribute for rust.toolchain() #3792
+415
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for reading Rust toolchain configuration from a rust-toolchain.toml file, allowing Bazel and cargo/rustup to share the same version specification. Supported fields: - channel: Maps to versions attribute - targets: Merged with extra_target_triples - components: Sets dev_components=True if "rustc-dev" present Supports both single-line and multi-line TOML arrays. Fixes bazelbuild#2753
UebelAndre
requested changes
Dec 21, 2025
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Have you thought about adding a new extension (toolchain_toml for example)? I'm wondering if it make sense in the context of a toml file to allow for varying rustfmt and rust-analyzer rustc versions, and extra target triples. Plus having attributes which end up doing nothing feels bad to me as it's easy to have side effects in future changes where both are set.
| parse_rust_toolchain_file_test = unittest.make(_parse_rust_toolchain_file_test_impl) | ||
|
|
||
| def rust_toolchain_toml_test_suite(name): | ||
| unittest.suite( |
Collaborator
There was a problem hiding this comment.
While it's a bit more verbose, can you use a native.test_suite? I find it much. more readable than the enumerated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for reading Rust toolchain configuration from a rust-toolchain.toml file, allowing Bazel and cargo/rustup to share the same version specification.
Supported fields:
Supports both single-line and multi-line TOML arrays.
Fixes #2753