Skip to content

pkg_install: make callable from a symbolic macro #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matx-sjacob wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

pkg_install: make callable from a symbolic macro #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/install.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ load("//pkg:providers.bzl", "PackageDirsInfo", "PackageFilegroupInfo", "PackageF
load("//pkg/private:pkg_files.bzl", "create_mapping_context_from_ctx", "process_src", "write_manifest")

def _pkg_install_script_impl(ctx):
script_file = ctx.actions.declare_file(ctx.attr.name + ".py")
script_file = ctx.outputs.out

mapping_context = create_mapping_context_from_ctx(ctx, label = ctx.label, default_mode = "0644")
for src in ctx.attr.srcs:
Expand Down Expand Up @@ -108,6 +108,10 @@ _pkg_install_script = rule(
],
doc = "Source mapping/grouping targets",
),
"out": attr.output(
mandatory = True,
doc = "Output path for the generated installer script. Must end in '.py'.",
),
"destdir": attr.string(),
"destdir_flag": attr.label(doc = "string flag to obtain destdir from"),
# This is private for now -- one could perhaps imagine making this
Expand Down Expand Up @@ -189,6 +193,7 @@ def pkg_install(name, srcs, destdir = None, destdir_flag = None, **kwargs):

_pkg_install_script(
name = name + "_install_script",
out = name + "_install_script.py",
srcs = srcs,
destdir = destdir,
destdir_flag = destdir_flag,
Expand Down
Loading