feat(pkg_files): auto-strip external package prefix #1004
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
force-pushed
the
make-pkg_files-auto-strip-prefix
branch
6 times, most recently
from
488745b to
ce924b0
Compare
When no explicit `strip_prefix` is specified, `pkg_files` now automatically preserves package-relative paths in two cases: 1. cross-workspace references: when an external workspace references files from the main workspace (e.g. `@external_repo//pkg:rule` using `@//tests:my_file`), 2. direct cross-package target references: when a target from a different package is directly referenced (i.e. not via a local `filegroup`) within the same workspace. The key is that the target being referenced must be from a different package, ensuring local `filegroup`s that aggregate files from other packages continue to use `basename`-only paths. This eliminates the need for explicit `strip_prefix` configurations in these pretty common cross-workspace and cross-package scenarios.
rdesgroppes
force-pushed
the
make-pkg_files-auto-strip-prefix
branch
from
ce924b0 to
7c12bd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no explicit
strip_prefixis specified,pkg_filesnow automatically preserves package-relative paths in two cases:@external_repo//pkg:ruleusing@//tests:my_file),filegroup) within the same workspace.The key is that the target being referenced must be from a different package, ensuring local
filegroups that aggregate files from other packages continue to usebasename-only paths.This eliminates the need for explicit
strip_prefixconfigurations in these pretty common cross-workspace and cross-package scenarios.