Skip to content

Do not percent-encode '+' in classpath-jar manifest Class-Path entries #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgalindo-sc wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Do not percent-encode '+' in classpath-jar manifest Class-Path entries #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java/bazel/rules/java_stub_template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,14 +315,14 @@ function create_classpath_jar() {
for path in ${CLASSPATH}; do
# Loop through the characters of the path and convert characters that are
# not alphanumeric nor -_.~/ to their 2-digit hexadecimal representation
if [[ ! $path =~ ^[-_.~/a-zA-Z0-9]*$ ]]; then
if [[ ! $path =~ ^[-_.~/a-zA-Z0-9+]*$ ]]; then
local i c buff
local converted_path=""

for ((i=0; i<${#path}; i++)); do
c=${path:$i:1}
case ${c} in
[-_.~/a-zA-Z0-9] ) buff=${c} ;;
[-_.~/a-zA-Z0-9+] ) buff=${c} ;;
* ) printf -v buff '%%%02x' "'$c'"
esac
converted_path+="${buff}"
Expand Down