Add objcopy_embed_data to legacy objcopy_files group#717
Open
shrey4796 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
keith
approved these changes
May 13, 2026
dzbarsky
reviewed
May 14, 2026
| Label("//cc/toolchains/actions:cpp_compile"), | ||
| Label("//cc/toolchains/actions:cpp_header_parsing"), | ||
| ], | ||
| # There are no actions listed for coverage and objcopy in action_names.bzl. |
Contributor
There was a problem hiding this comment.
this comment needs a tweak now right?
Author
There was a problem hiding this comment.
i was not sure. the actions for coverage (LLVM_COV or GCOV) and objcopy (OBJ_COPY_ACTION_NAME) are already defined in action_names.bzl. So this comment was already wrong. If you prefer, I can delete this comment completely
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.