Remove toolchain_identifier#549
Open
dzbarsky wants to merge 1 commit intobazelbuild:mainfrom
Open
Conversation
dzbarsky
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
dzbarsky
force-pushed
the
zbarsky/toolchain_identifier
branch
from
dc94436 to
9cc83d1
Compare
Collaborator
|
@trybka can we import this to see what it breaks? |
armandomontanez
added
P3
lilygorsheneva
previously approved these changes
Apr 8, 2026
Collaborator
|
can you sync / rebase and resolve the current test failures? |
dzbarsky
force-pushed
the
zbarsky/toolchain_identifier
branch
2 times, most recently
from
5d98aa6 to
7db2d4a
Compare
dzbarsky
force-pushed
the
zbarsky/toolchain_identifier
branch
from
7db2d4a to
751776d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CROSSTOOL has been ported to starlark so this is mostly unused now, except for the plumbing of a g3-specific define. If it's still desired, perhaps it can be achieved via
-Dcopt on the toolchain instead of special-casing g3 in rules_cc?