Remove allowlist_include_directories from data

[keith]

When very recent versions of bazel, improvements in the merkle tree
recommend that instead of passing a huge list of files to the toolchain,
you instead pass the root directory of those files once, and then bazel
symlinks the entire directory as opposed to every file one by one. In
order to do this you must pass a filegroup pointing at only the
directory. In this case, if you then also pass all the files, you get
conflicts in bazel trying to link the files, and the directory. If you
didn't get those conflicts you would still lose the perf benefits.

This change makes allowlist_include_directories only affect the
cxx_builtin_include_directories field. If you need the directory also in
data, you must now also add it to data. If you want to continue using
the entire list of files, that still works fine.

[matts1]

Tests appear to be broken, but LGTM otherwise

[armandomontanez]

Yeah, the tests ensure cxx_builtin_include_directories add files to toolchain file groups since it was part of the API contract.

[armandomontanez]

On that note, probably deserves a documentation update to clarify any changes in behavior.

Need to update tests/docs.

[keith]

updated tests and docs

[keith]

@armandomontanez friendly ping 🙏🏻

[matts1]

Our internal CI is complaining that //docs:toolchain_api_diff_test is failing. I would assume you updated the docs in starlark, but didn't regenerate them or something?

[keith]

thanks, updated

[keith]

@armandomontanez are you good with this one?

[trybka]

Approving based on Armando and Matt's prior approvals with the tests/docs now fixed (docs CI fixed elsewhere)

[armandomontanez]

Yes, thanks! Should go in shortly.