-
Notifications
You must be signed in to change notification settings - Fork 147
Add support to inject cc_feature into legacy toolchains #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This adds a parameter to unix cc_toolchain_config and windows cc_toolchain_config to be able to inject a cc_feature. This allows a user to inject a feature (for example for custom warnings) without having to reimplement the full toolchain. Resolves bazelbuild#517
This is required to be able to use it in the unix and windows toolchains that get generated in a separate repository.
|
I added to 0538f26 to see if the rest of the tests were passing. I believe that this is not wanted but I would ask for advice. The problem we have here is that the bzl file ends up in a generated repository. AFAIK there is no way or it is not a good practice to allow visibility to a specific named repository. |
|
Re: visibility I'd expect adding |
9a59372 to
eeb2411
Compare
|
@armandomontanez it does not work. It does not seem to be allowed to use the @ notation Error in visibility: invalid package name '@local_config_cc//...': must start with '//' or be 'public' or 'private' |
This is required to implement bazelbuild#517 For details see bazelbuild#525
This is required to implement bazelbuild#517 For details see bazelbuild#525
|
@armandomontanez could you provide guidance on which direction you would like me to take? For the providers file, if the direction is to make it public I created #540 |
This adds a parameter to unix cc_toolchain_config and windows cc_toolchain_config to be able to inject a cc_feature. This allows a user to inject a feature (for example for custom warnings) without having to reimplement the full toolchain.
Resolves #517