Skip to content

Runfiles import issues with rules_python 1.7.0 #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffhodsdon wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Runfiles import issues with rules_python 1.7.0 #2844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/bundletool/bundletool_experimental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def _post_process_bundle(self, bundle_root, post_processor):
# Configure the TREE_ARTIFACT_OUTPUT environment variable to the path of the
# bundle, but keep the work_dir for compatibility with the bundletool post
# processing.
exit_code = os.system('TREE_ARTIFACT_OUTPUT="%s" %s "%s"' %
exit_code = os.system('unset RUNFILES_MANIFEST_FILE; TREE_ARTIFACT_OUTPUT="%s" %s "%s"' %
(bundle_root, post_processor, work_dir))
if exit_code:
raise PostProcessorError(exit_code)
Expand All @@ -304,7 +304,7 @@ def _sign_bundle(self, bundle_root, command_lines):
executed in the bundle to sign it.
"""
exit_code = os.system(
'WORK_DIR=%s\n%s' % (shlex.quote(bundle_root), command_lines)
'unset RUNFILES_MANIFEST_FILE; WORK_DIR=%s\n%s' % (shlex.quote(bundle_root), command_lines)
)
if exit_code:
raise CodeSignError(exit_code)
Expand Down