Skip to content

Bzlmod examples - Fix errors with glog for Bazel@HEAD#654

Merged
meteorcloudy merged 1 commit intobazelbuild:mainfrom
kotlaja:fix_644
Jan 7, 2026
Merged

Bzlmod examples - Fix errors with glog for Bazel@HEAD#654
meteorcloudy merged 1 commit intobazelbuild:mainfrom
kotlaja:fix_644

Conversation

@kotlaja
Copy link
Copy Markdown
Contributor

@kotlaja kotlaja commented Jan 5, 2026

Fixes #644.

Glog repo needed patches in multiple places since it's missing load rules statements for Bazel@HEAD. Still, since glog is archived (https://github.com/google/glog), I've just switched to logging from absl.

@kotlaja kotlaja requested a review from Wyverald as a code owner January 5, 2026 21:15
@kotlaja kotlaja requested a review from meteorcloudy January 5, 2026 21:15
@gregestren
Copy link
Copy Markdown
Collaborator

How does #649 relate?

@mcantimu
Copy link
Copy Markdown

mcantimu commented Jan 7, 2026

How does #649 relate?

I think glog library has been deprecated and we should use ng-log library according the deprecation notice in https://github.com/google/glog

@meteorcloudy
Copy link
Copy Markdown
Member

ng-log doesn't work with Bazel 9 yet. Gemini camp up with similar changes in #648

Copy link
Copy Markdown
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy merged commit 67d73d7 into bazelbuild:main Jan 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bazel CI] ERROR: Bazel Analysis Error: no such target '@@glog+//:glog' referenced by '//:main'1

4 participants