toolchain: Switch to link_libs for libstdc++
#625
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
requested review from
dzbarsky,
fmeum,
helly25,
jsharpe and
rrbutani
as code owners
dzbarsky
approved these changes
Nov 27, 2025
Collaborator
dzbarsky
left a comment
dzbarsky
left a comment
There was a problem hiding this comment.
Thanks! Let's see if we break anyone :)
Not gonna block on this but it would be awesome to add a test with the sanitizer setup you were mentioning
Contributor
Author
|
id like to offer to add tests - but realistically im unlikely to have spare cycles for this just now - also our san setup is kinda specific to our ci build pipeline so isolating a minimal reproducer is not straightforward fwiw, the issue related to instrumented libc++ libs so not directly related to this pr - altho, i should say, we dont test clang+libstdc++ so this change is untested from our end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.