-
-
Notifications
You must be signed in to change notification settings - Fork 645
chore(bzlmod): assume that we can always mark the extension as reproducible #3444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(bzlmod): assume that we can always mark the extension as reproducible #3444
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request simplifies the bzlmod extension by removing a check for the extension_metadata_has_reproducible feature, which is now present in all supported Bazel versions. The change is correct and makes the code cleaner. I've added one suggestion to preserve a comment that explains why the extension is marked as reproducible, which I believe is useful for future maintenance.
| return module_ctx.extension_metadata( | ||
| reproducible = True, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change simplifies the logic correctly. However, the removed code contained a useful comment explaining why the extension is marked as reproducible. It would be beneficial for future maintainability to preserve this context. Consider adding a comment to explain the reasoning.
| return module_ctx.extension_metadata( | |
| reproducible = True, | |
| ) | |
| return module_ctx.extension_metadata( # PyPI index results are reproducible | |
| reproducible = True, | |
| ) |
As part of the previous bazel 6 and bazel 7 support cleanup, we probably should
have done this as well. All of the supported bazel versions allow us to mark
the extension as reproducible.