Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Dec 7, 2025

As part of the previous bazel 6 and bazel 7 support cleanup, we probably should
have done this as well. All of the supported bazel versions allow us to mark
the extension as reproducible.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the pip module extension for bzlmod by removing a redundant conditional check for the reproducible flag in extension_metadata. This change is based on the understanding that all currently supported Bazel versions inherently support marking extensions as reproducible, thus simplifying the codebase and aligning it with previous Bazel 6 and 7 support cleanups.

Highlights

  • Code Simplification: The conditional check for extension_metadata_has_reproducible within the _pip_impl function has been removed, simplifying the logic.
  • Dependency Removal: The bazel_features module is no longer loaded, as its functionality related to reproducible metadata is now assumed to be universally available across supported Bazel versions.
  • Reproducibility Assumption: The pip module extension now unconditionally marks itself as reproducible, reflecting that all supported Bazel versions allow this behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the bzlmod extension by removing a check for the extension_metadata_has_reproducible feature, which is now present in all supported Bazel versions. The change is correct and makes the code cleaner. I've added one suggestion to preserve a comment that explains why the extension is marked as reproducible, which I believe is useful for future maintenance.

Comment on lines +387 to +389
return module_ctx.extension_metadata(
reproducible = True,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change simplifies the logic correctly. However, the removed code contained a useful comment explaining why the extension is marked as reproducible. It would be beneficial for future maintainability to preserve this context. Consider adding a comment to explain the reasoning.

Suggested change
return module_ctx.extension_metadata(
reproducible = True,
)
return module_ctx.extension_metadata( # PyPI index results are reproducible
reproducible = True,
)

@rickeylev rickeylev added this pull request to the merge queue Dec 10, 2025
Merged via the queue into bazel-contrib:main with commit 89c8f20 Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants