Skip to content

Revert "Revert "Revert "Revert "test-4-cli"""" #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yuvalyacoby wants to merge 17 commits into from
Closed

Revert "Revert "Revert "Revert "test-4-cli"""" #53

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c5ed4f3
Revert "Revert "Revert "Revert "test (#49)" (#50)" (#51)" (#52)"
yuvalyacoby Dec 25, 2025
0ba6ac9
test
yuvalyacoby Dec 25, 2025
b696d76
Fix NameError: use b2 instead of b in roots
Jan 11, 2026
2542e25
Revert "Fix NameError: use b2 instead of b in roots"
yuvalyacoby Jan 11, 2026
18d647a
Fix NameError: use b2 instead of b in roots
yuvalyacoby Jan 11, 2026
ed7e5f7
Revert "Fix NameError: use b2 instead of b in roots"
yuvalyacoby Jan 11, 2026
08a9c4d
Fix NameError: use b2 instead of b in roots calc
Jan 11, 2026
3698c40
Revert "Fix NameError: use b2 instead of b in roots calc"
yuvalyacoby Jan 11, 2026
27eb49d
Fix NameError: use b2 instead of b in roots
Jan 11, 2026
1631883
Revert "Fix NameError: use b2 instead of b in roots"
yuvalyacoby Jan 11, 2026
cc9f2f6
Fix NameError: use b2 instead of undefined b
baz-app-dev[bot] Jan 11, 2026
584f67d
Revert "Fix NameError: use b2 instead of undefined b"
yuvalyacoby Jan 11, 2026
c51cb89
Fix NameError: use b2 instead of undefined b
baz-app-dev[bot] Jan 14, 2026
6f2c7b8
I haven't made any changes to the codebase. The fix mentioned in the …
baz-app-dev[bot] Jan 14, 2026
72cc1b9
Fix NameError: use b2 instead of undefined b
baz-app-dev[bot] Jan 15, 2026
5c39fae
Revert "Fix NameError: use b2 instead of b in roots"
yuvalyacoby Jan 15, 2026
c682538
Fix NameError: use b2 instead of b in roots
baz-app-dev[bot] Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/edits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
d = (b2 ** 2) - (4 * a * c)

# find two solutions
sol1 = (-b2 - cmath.sqrt(d)) / (2 * a)
sol2 = (-b2 + cmath.sqrt(d)) / (2 * a)
sol1 = (-b2-cmath.sqrt(d))/(2*a)
sol2 = (-b2+cmath.sqrt(d))/(2*a)
sol23 = (-b2+cmath.sqrt(d))/(2*a)

Comment on lines 17 to 23
Copy link
Copy Markdown

@baz-reviewer baz-reviewer Bot Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The roots use -b/+b, but only b2 is defined—this will raise a NameError. Should both the discriminant and roots use b2 consistently?

Suggested change
d = (b2 ** 2) - (4 * a * c)
# find two solutions
sol1 = (-b2 - cmath.sqrt(d)) / (2 * a)
sol2 = (-b2 + cmath.sqrt(d)) / (2 * a)
sol1 = (-b-cmath.sqrt(d))/(2*a)
sol2 = (-b+cmath.sqrt(d))/(2*a)
sol23 = (-b+cmath.sqrt(d))/(2*a)
d = (b2 ** 2) - (4 * a * c)
# find two solutions
sol1 = (-b2-cmath.sqrt(d))/(2*a)
sol2 = (-b2+cmath.sqrt(d))/(2*a)

Finding types: Logical Bugs Basic Security Patterns

Copy link
Copy Markdown

@baz-reviewer baz-reviewer Bot Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit b696d76 addressed this comment. The code was updated to consistently use b2 instead of b in all root calculations (sol1, sol2, and sol23), fixing the NameError bug and making the code consistent with the discriminant calculation.

print('The solution are {0} and {1}'.format(sol1, sol2))

Expand Down
2 changes: 2 additions & 0 deletions typescript/nestjs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Grabbed from:
https://github.com/nestjs/nest/tree/master/sample/01-cats-app

some commit data