Make Print Functions Consistent with --keep-empty-lines#12
Open
CauhxMilloy wants to merge 1 commit intobats-core:mainfrom
Open
Make Print Functions Consistent with --keep-empty-lines#12CauhxMilloy wants to merge 1 commit intobats-core:mainfrom
--keep-empty-lines#12CauhxMilloy wants to merge 1 commit intobats-core:mainfrom
Conversation
* Updating `batslib_count_lines` to automatically detect trailing newlines and count them if present. * This works on the concept that a string has a trailing newline if it was intended -- e.g. via `run --keep-empty-lines` or similar. * Updating `batslib_prefix` and `batslib_mark` to accept `--keep-empty-lines` option to properly print empty lines and trailing newlines. * Updating `batslib_print_kv_single_or_multi` calls to `batslib_prefix`. * Will automatically detect trailing new lines (on a per-value basis). * If trailing newline is present, `--keep-empty-lines` will be passed to `batslib_prefix`. This implements option 4 for `batslib_count_lines` and `batslib_print_kv_single_or_multi`, and option 2 for `batslib_prefix` and `batslib_mark`, as discussed in bats-core#11. Fixes bats-core#11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batslib_count_linesto automatically detect trailing newlines and count them if present.run --keep-empty-linesor similar.batslib_prefixandbatslib_markto accept--keep-empty-linesoption to properly print empty lines and trailing newlines.batslib_print_kv_single_or_multicalls tobatslib_prefix.--keep-empty-lineswill be passed tobatslib_prefix.This implements option 4 for
batslib_count_linesandbatslib_print_kv_single_or_multi, and option 2 forbatslib_prefixandbatslib_mark, as discussed in #11.Fixes #11.