fix(dev): always warn when creating worktree on existing branch#430
Closed
basnijholt wants to merge 1 commit intomainfrom
Closed
fix(dev): always warn when creating worktree on existing branch#430basnijholt wants to merge 1 commit intomainfrom
basnijholt wants to merge 1 commit intomainfrom
Conversation
Previously, `dev new` only warned about reusing an existing branch when `--from` was also specified. Without `--from`, it silently checked out the existing branch, which is surprising when the intent is to start fresh. Now a warning is shown in both cases with context-appropriate messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev newnow always warns when the specified branch name already exists in git, not just when--fromis also specified--from: shows"Branch 'X' already exists. Using existing branch (use a different name to start fresh)."--from: keeps the existing message"Branch 'X' already exists. Using existing branch instead of creating from 'Y'."Previously,
dev new my-existing-branchwould silently check out the existing branch without any indication, which is surprising when the user's intent is to start fresh.Test plan
test_no_warning_when_from_not_specified→test_warning_when_from_not_specified_but_branch_existsto assert warning is shown