refactor: deduplicate optional extras using self-referencing dependencies#427
Merged
basnijholt merged 4 commits intomainfrom Feb 12, 2026
Merged
refactor: deduplicate optional extras using self-referencing dependencies#427basnijholt merged 4 commits intomainfrom
basnijholt merged 4 commits intomainfrom
Conversation
…cies Introduce a `vectordb` base extra to eliminate duplication between `rag` and `memory` (which shared 8 identical deps). Replace repeated `fastapi[standard]` in 7 extras with `agent-cli[server]` references.
Owner
Author
|
pre-commit.ci: please retry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vectordbbase extra that captures the 8 shared dependencies betweenragandmemory(chromadb, pydantic-ai, openai, onnxruntime, huggingface-hub, transformers, watchfiles, and fastapi)fastapi[standard]in 7 extras (rag,memory,faster-whisper,mlx-whisper,whisper-transformers,piper,kokoro) withagent-cli[server]self-referencesragandmemoryfrom ~8 lines each to 1-line self-references plus their unique depBefore:
After:
Uses the same self-referencing pattern already established by
audio = [..., "agent-cli[wyoming]"].Test plan
check-extras-sync,sync-requirements,uv lock)_extras.jsonand_requirements/*.txtregenerated correctlyvectordbadded toinstall-extrashelp text and docstring