feat(modules): plugins/modules architecture #14
Open
danielhe4rt wants to merge 3 commits intomainfrom
Open
Conversation
gvieira18
requested changes
Nov 26, 2024
Member
gvieira18
left a comment
There was a problem hiding this comment.
The files rust-toolchain.toml, rustfmt.toml and Makefile are missing from the src-plugins folder. The changes to the CI files are also mentioned, but for these in particular you can ignore them and I'll update them later.
Run make check after adding the remaining files please.
| @@ -0,0 +1,6 @@ | |||
| [workspace] | |||
Member
There was a problem hiding this comment.
Apparently the resolver directive is missing
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the plugin architecture and documentation, focusing on the addition of a new plugin system and the implementation of a Rust-based plugin for OBS (Open Broadcaster Software). The most important changes include the addition of a new plugin skeleton, the creation of an OBS plugin, and updates to the documentation to reflect these changes.
Module/Plugin Configuration
Inside the
ModuleActionyou can find anVec<ModuleSettings>property which will holds all information you need tobuild the settings page inside the application. You can think into something which will holds any metadata needed to
perform the module action. E.g:
This will be stored together with the user profile and should be sent to every request arg as
{module}_{settings}.Imagine that we have two different modules being
TwitchandOBS:you would be able to use these informations inside the module actions: