Add release notes tooltip to waybar update indicator#4904
Closed
syabro wants to merge 1 commit intobasecamp:devfrom
Closed
Add release notes tooltip to waybar update indicator#4904syabro wants to merge 1 commit intobasecamp:devfrom
syabro wants to merge 1 commit intobasecamp:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds richer hover/click behavior for the Waybar update indicator by switching the module to JSON output and introducing a new helper script that fetches and formats GitHub release notes.
Changes:
- Update
custom/updateWaybar module to usereturn-type: json, call the new tooltip script, and add a right-click action for full notes. - Add
omarchy-update-available-tooltipscript to detect pending updates, fetch release notes viagh api, and emit JSON with a Pango-formatted tooltip.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/waybar/config.jsonc | Switches update module to JSON output, new exec script, and adds right-click for full release notes. |
| bin/omarchy-update-available-tooltip | New script that checks tags, fetches release notes, builds tooltip/full text, and outputs Waybar JSON. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
|
We've looked at this a few times in the past, and I think we're better off just leaning on the link to the latest releases when you click to update. That also accommodates for the fact that someone might be multiple versions behind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$EDITORomarchy-updateas beforeChanges
bin/omarchy-update-available-tooltip— new script that fetches release notes viagh apiand outputs JSON for waybar with Pango-formatted tooltipconfig/waybar/config.jsonc— updatedcustom/updatemodule to usereturn-type: jsonand the new scriptDependencies
gh(GitHub CLI) — for fetching release notes via APIjq— for JSON output formattingScreen