Bundle Zed editor with omazed for themes syncing#4873
Bundle Zed editor with omazed for themes syncing#4873pomartel wants to merge 6 commits intobasecamp:devfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm just not sure how we handle AUR packages in Omarchy. Maybe this should come with a prompt. |
|
Given the new theme template system, I'd be willing to take a single zed tpl file instead of adding this dependency. |
|
@APS6 Do you think that's something that could be done? I would very like to have this merged in Omarchy but it's your project and I don't want to intercede. |
pomartel
changed the title
|
@dhh I extracted the Omazed templating rules and used the same logic as we have in place for VS Code. I tested it thoroughly and I think it's as minimal as it can be. |
|
Oh wow. I'm surprised that it's such a huge chunk. I would have thought we could have gotten away with something on the scale of Alacritty or Ghostty. Hmm. Don't see us taking on ~700 lines of code for an optional editor, then. |
|
@pomartel Sorry for not replying earlier. I forgot to respond in the midst of my examinations. @dhh Yeah, editor themes are quite complex. I explained my reasoning earlier in detail here: APS6/omazed#4 (comment) |
|
Okay, given all this, I'm happy to just installed omazed when we install zed via the menu 👍 |
pomartel
changed the title
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
LGTM 👍 |
|
@dhh Hey, it's been a while so I figured I should ask if we are waiting for something specific? |
Omazed provides live theme switching for the Zed editor. It is maintained as an AUR package by @APS6. It uses Omarchy's themes hooks and
color.toml. I have been using it for a while and it works very well.This PR bundles omazed with Zed when installing it from the Editors menu.