Update icons.theme to use Yaru-dark instead of Yaru-gray#4872
Closed
xcession wants to merge 1 commit intobasecamp:devfrom
Closed
Update icons.theme to use Yaru-dark instead of Yaru-gray#4872xcession wants to merge 1 commit intobasecamp:devfrom
xcession wants to merge 1 commit intobasecamp:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Vantablack theme’s icon theme reference to a valid Yaru variant so the system doesn’t fall back to Adwaita when applying icons.
Changes:
- Switch
themes/vantablack/icons.themefromYaru-gray(nonexistent) toYaru-dark(available).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thank you. I forgot to fix this myself! |
Member
|
I actually think what we have now, the fallback icons, work better. Even if it's a mistake. The yaru-dark has a lot of color, and the whole point is for this to be monochrome. So I'd take a fix that just sets it correctly to what we already have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since "Yaru-gray" does not exist in the default Yaru package, the theme unintentionally falls back to Adwaita. This fixes the issue by switching to "Yaru-dark", the closest available replacement for the theme's