#201 | Enhanced tenanted and untenanted associations

[miguelmarcondesf]

feature: Easy associations between tenanted and untenanted models

enhance active record associations to detect if they're between a tenanted model and an untenanted model, and in that case do the extra work to make sure the tenant is respected.

Checklist:

• has_one
• has_many
• belongs_to
• Fixtures double check

[flavorjones]

Hi! Thanks for opening this draft. I'll dig in and review as soon as I can find time!

[flavorjones]

Sorry, it's been a busy week. I will definitely get to this soon!

[flavorjones]

I'm not sure this is the right direction. I know in the original description I suggested something like .where(tenant_id: tenant) but that was meant to be illustrative.

The general problem that I personally need to solve is for a model where the tenant ID is not in the database.

[flavorjones]

Hmm. Please ignore my review for now, I'm still wrapping my head around the problem and this approach.

[flavorjones]

This is a good start on a very complex feature. I'm not at all sure how belongs_to might be implemented, but this seems like a promising direction for the has_one and has_many side of the association.

[flavorjones]

Ideally I'd like to be able to do this in an untenanted scope, but it looks like AR does some validation that requires a tenanted connection ...

I'd also like to be able to do this without explicitly setting the tenant id in Announcement, that is:

Announcement.create! user: user

should set the tenant column automatically.

[miguelmarcondesf]

So do we want to set this tenant column automatically even for untenanted ones?
For this specific case, User is tenanted by TenantedApplicationRecord and Annoucement is using SharedApplicationRecord
I can't find a simple way to manage the ActiveRecord call to the untenanted ones unless we transform them into Subtenanted ones 🤔

[miguelmarcondesf]

This is a good start on a very complex feature. I'm not at all sure how belongs_to might be implemented, but this seems like a promising direction for the has_one and has_many side of the association.

@flavorjones Thanks for the awesome feedback, I'll try to get back to work here later this week!

[miguelmarcondesf]

Hey @flavorjones
I made the changes you requested and added a belongs_to implementation following your suggestions.
Please, when you have time, I would be grateful for another review.